Skip to content

RFC simple-card: Improve probe's error messages

Fabio Forni linux-sound lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ASoC: simple-card: Do not print "parse error" twicesound/soc/generic/simple-card.c+1 -32 replies
2/3ASoC: simple-card: Replace "parse error" with a more descriptive msgsound/soc/generic/simple-card.c+1 -10 replies
3/3ASoC: simple-card: Split alloc and init logics in probe functionsound/soc/generic/simple-card-utils.c sound/soc/generic/simple-card.c+81 -655 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/3] simple-card: Improve probe's error messages

Hello,

this patch tries to improve errors messages that are printed by the probe function of simple-card. Some messages were missing and I think that made debugging difficult, others were printed even though the underlying error is unrelated (e.g. when devm_snd_soc_register_card is called).

This series is tagged as RFC because it's my first contribution. Plus, patch number 3 touches many lines. I'm not sure I'm allowed to touch so many lines in one run, also I need more than a pair of eyes because even though patch #3 is just a refactor, I'm not 100% familiar with ASoC.

Fabio Forni (3):
ASoC: simple-card: Do not print "parse error" twice
ASoC: simple-card: Replace "parse error" with a more descriptive msg
ASoC: simple-card: Split alloc and init logics in probe function

 sound/soc/generic/simple-card-utils.c |   9 ++
 sound/soc/generic/simple-card.c       | 141 +++++++++++++-------------
 2 files changed, 82 insertions(+), 68 deletions(-)
Signature · 1 line
2.52.0