KVM: x86: nSVM: Improve PAT virtualization
Status from this message: Applied to kvm-x86 svm. Yosry and/or Jim, please double check the result, the
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v8 Latest7 of 8 patches 3 repliesApplied
- v79 patches 13 repliesSuperseded
- v610 patches 1 replySuperseded
Earlier versions · 5
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v5 | 10 patches | 11 replies | Applied | |
| v4 | 8 patches | 25 replies | Superseded | |
| v3 | 8 patches | 14 replies | Superseded | |
| v2 | 8 patches | 12 replies | Superseded | |
| v1 | 10 patches | 4 replies | Superseded |
Changes in v8 from the cover letter
* Indentation changes to conform to Sean's aesthetic [Sean]
* Updated comment in svm_pat_accesses_gpat() [Sean]
* Restored the common behavior for get/set IA32_PAT [Sean]
* Reordered declarations in svm_set_nested_state() for ASCII art [Sean]
* Dropped the selftest [Sean]
7 of 8 patches are in this archive. The cover letter announces 8.
Patches in v8 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | KVM: x86: Define KVM_X86_QUIRK_NESTED_SVM_SHARED_PATDocumentation/ arch/ arch/ +1 more | +27 | 0 replies | |
| 2/8 | KVM: x86: nSVM: Clear VMCB_NPT clean bit when updating hPAT from guest modearch/ arch/ arch/ | +8 | 0 replies | |
| 3/8 | KVM: x86: nSVM: Cache and validate vmcb12 g_patarch/ arch/ | +20 | 0 replies | |
| 4/8 | KVM: x86: nSVM: Set vmcb02.g_pat correctly for nested NPTarch/ | +7 | 0 replies | |
| 6/8 | KVM: x86: nSVM: Save gPAT to vmcb12.g_pat on VMEXITarch/ | +3 | 0 replies | |
| 7/8 | KVM: Documentation: document KVM_{GET,SET}_NESTED_STATE for SVMDocumentation/ | +11 | 0 replies | |
| 8/8 | KVM: x86: nSVM: Save/restore gPAT with KVM_{GET,SET}_NESTED_STATEDocumentation/ arch/ arch/ | +21 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v8 yet.
Cover letter [PATCH v8 0/8] KVM: x86: nSVM: Improve PAT virtualization
Currently, KVM's implementation of nested SVM treats the PAT MSR the same way whether or not nested NPT is enabled: L1 and L2 share a single PAT. However, the AMD APM specifies that when nested NPT is enabled, the host (L1) and the guest (L2) should have independent PATs: hPAT for L1 and gPAT for L2.
This patch series implements independent PATs for L1 and L2 when nested NPT is enabled, but only when a new quirk, KVM_X86_QUIRK_NESTED_SVM_SHARED_PAT, is disabled. By default, the quirk is enabled, preserving KVM's legacy behavior. When the quirk is disabled, KVM correctly virtualizes a separate PAT register for L2, using the g_pat field in the VMCB.
Guest accesses to the IA32_PAT MSR are redirected to either hPAT or gPAT depending on the current mode and whether nested NPT is enabled. All other accesses, including userspace accesses via KVM_{GET,SET}_MSRS, continue to reference hPAT. L2's gPAT is saved and restored via a new 'gpat' field in kvm_svm_nested_state_hdr, which is within the existing padding of the header to maintain ABI compatibility.
v1: https://lore.kernel.org/kvm/[email protected]/
v2: https://lore.kernel.org/kvm/[email protected]/
v3: https://lore.kernel.org/kvm/[email protected]/
v4: https://lore.kernel.org/kvm/[email protected]/
v5: https://lore.kernel.org/kvm/[email protected]/
v6: https://lore.kernel.org/kvm/[email protected]/
v7: https://lore.kernel.org/kvm/[email protected]/
v7 -> v8:
* Indentation changes to conform to Sean's aesthetic [Sean]
* Updated comment in svm_pat_accesses_gpat() [Sean]
* Restored the common behavior for get/set IA32_PAT [Sean]
* Reordered declarations in svm_set_nested_state() for ASCII art [Sean]
* Dropped the selftest [Sean]
Jim Mattson (8):
KVM: x86: Define KVM_X86_QUIRK_NESTED_SVM_SHARED_PAT
KVM: x86: nSVM: Clear VMCB_NPT clean bit when updating hPAT from guest
mode
KVM: x86: nSVM: Cache and validate vmcb12 g_pat
KVM: x86: nSVM: Set vmcb02.g_pat correctly for nested NPT
KVM: x86: nSVM: Redirect IA32_PAT accesses to either hPAT or gPAT
KVM: x86: nSVM: Save gPAT to vmcb12.g_pat on VMEXIT
KVM: Documentation: document KVM_{GET,SET}_NESTED_STATE for SVM
KVM: x86: nSVM: Save/restore gPAT with KVM_{GET,SET}_NESTED_STATE
Documentation/virt/kvm/api.rst | 26 ++++++++++++++ arch/x86/include/asm/kvm_host.h | 3 +- arch/x86/include/uapi/asm/kvm.h | 2 ++ arch/x86/kvm/svm/nested.c | 64 ++++++++++++++++++++++++--------- arch/x86/kvm/svm/svm.c | 41 +++++++++++++++++---- arch/x86/kvm/svm/svm.h | 18 +++++++++- 6 files changed, 130 insertions(+), 24 deletions(-)
Signature · 1 line
2.53.0.1213.gd9a14994de-goog