Skip to content

mm/damon: advance DAMOS-based LRU sorting

SeongJae Park damon linux-doc linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 9 repliesIn review 9 of 11 applied

Patches in v1 9 of 11 applied

#Subject and filesSizeRepliesApplied
1/11mm/damon/core: introduce [in]active memory ratio damos quota goal metricinclude/linux/damon.h mm/damon/core.c+26 -00 replies
2/11mm/damon/sysfs-schemes: support DAMOS_QUOTA_[IN]ACTIVE_MEM_BPmm/damon/sysfs-schemes.c+8 -02 repliesApplied
3/11Docs/mm/damon/design: document DAMOS_QUOTA_[IN]ACTIVE_MEM_BPDocumentation/mm/damon/design.rst+4 -01 replyApplied
4/11mm/damon/paddr: activate DAMOS_LRU_PRIO targets instead of marking accessedmm/damon/paddr.c+8 -100 repliesApplied
5/11mm/damon/lru_sort: consider age for quota prioritizationmm/damon/lru_sort.c+1 -10 repliesApplied
6/11mm/damon/lru_sort: support young page filtersmm/damon/lru_sort.c+41 -00 repliesApplied
7/11Docs/admin-guide/mm/damon/lru_sort: document filter_young_pagesDocumentation/admin-guide/mm/damon/lru_sort.rst+14 -01 replyApplied
8/11mm/damon/lru_sort: support active:inactive memory ratio based auto-tuningmm/damon/lru_sort.c+37 -02 replies
9/11Docs/admin-guide/mm/damon/lru_sort: document active_mem_bp parameterDocumentation/admin-guide/mm/damon/lru_sort.rst+12 -01 replyApplied
10/11mm/damon/lru_sort: add monitoring intervals auto-tuning parametermm/damon/lru_sort.c+27 -31 replyApplied
11/11Docs/admin-guide/mm/damon/lru_sort: document intervals autotuningDocumentation/admin-guide/mm/damon/lru_sort.rst+11 -01 replyApplied

Reviews trailers per patch

6 of 11 patches have a Reviewed-by or Acked-by.

Patchwang lian
1/11
2/11A-b A-b
3/11A-b
4/11
5/11
6/11
7/11A-b
8/11
9/11A-b
10/11A-b
11/11A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] mm/damon: advance DAMOS-based LRU sorting

DAMOS_LRU_[DE]PRIO actions were added to DAMOS for more access-aware LRU lists sorting. For simple usage, a specialized kernel module, namely DAMON_LRU_SORT, has also been introduced. After the introduction of the module, DAMON got a few important new features, including the aim-based quota auto-tuning, age tracking, young page filter, and monitoring intervals auto-tuning. Meanwhile, DAMOS-based LRU sorting had no direct updates. Now we show some rooms to advance for DAMOS-based LRU sorting.

Firstly, the aim-oriented quota auto-tuning can simplify the LRU sorting parameters tuning. But there is no good auto-tuning target metric for LRU sorting use case. Secondly, the behavior of DAMOS_LRU_[DE]PRIO are not very symmetric. DAMOS_LRU_DEPRIO directly moves the pages to inactive LRU list, while DAMOS_LRU_PRIO only marks the page as accessed, so that the page can not directly but only eventually moved to the active LRU list. Finally, DAMON_LRU_SORT users cannot utilize the modern features that can be useful for them, too.

Improve the situation with the following changes. First, introduce a new DAMOS quota auto-tuning target metric for active:inactive memory size ratio. Since LRU sorting is a kind of balancing of active and inactive pages, the active:inactive memory size ratio can be intuitively set. Second, update DAMOS_LRU_[DE]PRIO behaviors to be more intuitive and symmetric, by letting them directly move the pages to [in]active LRU list. Third, update the DAMON_LRU_SORT module user interface to be able to fully utilize the modern features including the [in]active memory size ratio-based quota auto-tuning, young page filter, and monitoring intervals auto-tuning.

With these changes, for example, users can now ask DAMON to "find hot/cold memory regions with auto-tuned monitoring intervals, do one more page level access check for found hot/cold memory, and move pages of those to active or inactive LRU lists accordingly, aiming X:Y active to inactive memory ratio." For example, if they know 30% of the memory is better to be protected from reclamation, 30:70 can be set as the target ratio.

Test Results
------------

I ran DAMON_LRU_SORT with the features introduced by this series, on a real world server workload. For the active:inactive ratio goal, I set 50:50. I confirmed it achieves the target active:inactive ratio, without manual tuning of the monitoring intervals and the hot/coldness thresholds. The baseline system that was not running the DAMON_LRU_SORT was keeping active:inactive ratio of about 1:10.

Note that the test didn't show a clear performance difference, though. I believe that was mainly because the workload was not very memory intensive. Also, whether the 50:50 target ratio was optimum is unclear. Nonetheless, the positive performance impact of the basic LRU sorting idea is already confirmed with the initial DAMON_LRU_SORT introduction patch series. The goal of this patch series is simplifying the parameters tuning of DAMOS-based LRU sorting, and the test confirmed the aimed goals are achieved.

Patches Sequence
----------------

First three patches extend DAMOS quota auto-tuning to support [in]active memory ratio target metric type. Those (patches 1-3) introduce new metrics, implement DAMON sysfs support, and update the documentation, respectively.

Following patch (patch 4) makes DAMOS_LRU_PRIO action to directly move target pages to active LRU list, instead of only marking them accessed.

Following seven patches (patches 5-11) updates DAMON_LRU_SORT to support modern DAMON features. Patch 5 makes it uses not only access frequency but also age at under-quota regions prioritization. Patches 6-11 add the support for young page filtering, active:inactive memory ratio based quota auto-tuning, and monitoring intervals auto-tuning, with appropriate document updates.

Changes from RFC
(https://lore.kernel.org/[email protected])
- rebase to latest mm-new
- add test results on the cover letter
- minor wordsmithing and typo fixes

SeongJae Park (11):
mm/damon/core: introduce [in]active memory ratio damos quota goal
metric
mm/damon/sysfs-schemes: support DAMOS_QUOTA_[IN]ACTIVE_MEM_BP Docs/mm/damon/design: document DAMOS_QUOTA_[IN]ACTIVE_MEM_BP mm/damon/paddr: activate DAMOS_LRU_PRIO targets instead of marking
accessed
mm/damon/lru_sort: consider age for quota prioritization mm/damon/lru_sort: support young page filters Docs/admin-guide/mm/damon/lru_sort: document filter_young_pages mm/damon/lru_sort: support active:inactive memory ratio based
auto-tuning
Docs/admin-guide/mm/damon/lru_sort: document active_mem_bp parameter mm/damon/lru_sort: add monitoring intervals auto-tuning parameter Docs/admin-guide/mm/damon/lru_sort: document intervals autotuning

 .../admin-guide/mm/damon/lru_sort.rst         |  37 ++++++
 Documentation/mm/damon/design.rst             |   4 +
 include/linux/damon.h                         |   4 +
 mm/damon/core.c                               |  22 ++++
 mm/damon/lru_sort.c                           | 110 +++++++++++++++++-
 mm/damon/paddr.c                              |  18 ++-
 mm/damon/sysfs-schemes.c                      |   8 ++
 7 files changed, 189 insertions(+), 14 deletions(-)

base-commit: 7a1491b1b0a461872951e8fdf885fc243f67f5e4

Signature · 1 line
2.47.3