Skip to content

ice: fix AQ command 0x06EE usage by retrying

Dawid Osuchowski intel-wired-lan netdev stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ice: reintroduce retry mechanism for indirect AQdrivers/net/ethernet/intel/ice/ice_common.c+9 -33 replies
2/2ice: fix retry for AQ command 0x06EEdrivers/net/ethernet/intel/ice/ice_common.c drivers/net/ethernet/intel/ice/ice_ethtool.c+15 -212 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchAleksandr LoktionovPrzemek KitszelPaul MenzelRinitha S
1/2R-b R-b R-b T-b
2/2R-b R-b R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH iwl-net 0/2] ice: fix AQ command 0x06EE usage by retrying

The Admin Queue (AQ) command 0x06EE can return EBUSY when firmware link management holds the i2c bus used to communicate with the module.

According to Intel(R) Ethernet Controller E810 Datasheet Rev 2.8 [1] Section 3.3.10.4 Read/Write SFF EEPROM (0x06EE)
request should be retried upon receiving EBUSY from firmware.

Instead of relying on the caller of ice_aq_sff_eeprom() to implement retrying, use the existing retry infrastructure in ice_sq_send_cmd_retry() to always attempt retry on receiving EBUSY.

Reproduction steps
------------------

	# ethtool -m <interface_name>
	netlink error: Input/output error

Jakub Staniszewski (2):
ice: reintroduce retry mechanism for indirect AQ
ice: fix retry for AQ command 0x06EE

 drivers/net/ethernet/intel/ice/ice_common.c  | 13 ++++++--
 drivers/net/ethernet/intel/ice/ice_ethtool.c | 35 ++++++++------------
 2 files changed, 24 insertions(+), 24 deletions(-)

base-commit: 855e576f30278714c7ca067005f46807aca2e6d4

Signature · 1 line
2.51.0