mm: balloon infrastructure cleanups
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest24 patches 2 repliesIn review 23 of 24 applied
- v223 patches 41 repliesSuperseded
Changes in v3 from the cover letter
* "mm/balloon_compaction: centralize basic page migration handling" -> Remove newline
-> Talk about "page" instead of "old page"
-> avoid the switch statement
* "mm/balloon_compaction: move internal helpers to balloon_compaction.c" -> No need to carry over the "inline"
* "fixup mm: rename CONFIG_BALLOON_COMPACTION to CONFIG_BALLOON_MIGRATION -> Remove some more "balloon page compaction" thingies
* "MAINTAINERS: move memory balloon infrastructure to "MEMORY MANAGEMENT - BALLOON"
-> CC the virt list and use the proper mail address
* "mm/balloon_compaction: improve comments for WARN_ON_ONCE(!b_dev_info) -> Added
Patches in v3 23 of 24 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/24 | vmw_balloon: adjust BALLOON_DEFLATE when deflating while migratingdrivers/ | +2 | 0 replies | Applied |
| 2/24 | vmw_balloon: remove vmballoon_compaction_init()drivers/ | +5 | 0 replies | Applied |
| 3/24 | powerpc/pseries/cmm: remove cmm_balloon_compaction_init()arch/ | +5 | 0 replies | Applied |
| 4/24 | mm/balloon_compaction: improve comments for WARN_ON_ONCE(!b_dev_info)mm/ | +10 | 0 replies | Applied |
| 5/24 | mm/balloon_compaction: centralize basic page migration handlingarch/ drivers/ drivers/ +1 more | +35 | 0 replies | Applied |
| 6/24 | mm/balloon_compaction: centralize adjust_managed_page_count() handlingarch/ drivers/ include/ +1 more | +22 | 0 replies | Applied |
| 7/24 | vmw_balloon: stop using the balloon_dev_info lockdrivers/ | +12 | 0 replies | Applied |
| 8/24 | mm/balloon_compaction: use a device-independent balloon (list) lockinclude/ mm/ | +22 | 0 replies | Applied |
| 9/24 | mm/balloon_compaction: remove dependency on page lockinclude/ mm/ | +25 | 0 replies | Applied |
| 10/24 | mm/balloon_compaction: make balloon_mops staticinclude/ mm/ | +1 | 0 replies | Applied |
| 11/24 | mm/balloon_compaction: drop fs.h include from balloon_compaction.hinclude/ | +0 | 0 replies | Applied |
| 12/24 | drivers/virtio/virtio_balloon: stop using balloon_page_push/pop()drivers/ | +15 | 0 replies | Applied |
| 13/24 | mm/balloon_compaction: remove balloon_page_push/pop()include/ mm/ | +2 | 0 replies | Applied |
| 14/24 | mm/balloon_compaction: fold balloon_mapping_gfp_mask() into balloon_page_alloc()include/ mm/ | +8 | 0 replies | Applied |
| 15/24 | mm/balloon_compaction: move internal helpers to balloon_compaction.cinclude/ mm/ | +38 | 1 reply | |
| 16/24 | mm/balloon_compaction: assert that the balloon_pages_lock is heldmm/ | +2 | 0 replies | Applied |
| 17/24 | mm/balloon_compaction: mark remaining functions for having proper kerneldocmm/ | +5 | 0 replies | Applied |
| 18/24 | mm/balloon_compaction: remove "extern" from functionsinclude/ | +8 | 0 replies | Applied |
| 19/24 | mm/vmscan: drop inclusion of balloon_compaction.hmm/ | +0 | 0 replies | Applied |
| 20/24 | mm: rename balloon_compaction.(c|h) to balloon.(c|h)Documentation/ MAINTAINERS arch/ +5 more | +15 | 0 replies | Applied |
| 21/24 | mm/kconfig: make BALLOON_COMPACTION depend on MIGRATIONmm/ | +7 | 0 replies | Applied |
| 22/24 | mm: rename CONFIG_BALLOON_COMPACTION to CONFIG_BALLOON_MIGRATIONDocumentation/ arch/ drivers/ +8 more | +35 | 0 replies | Applied |
| 23/24 | mm: rename CONFIG_MEMORY_BALLOON -> CONFIG_BALLOONarch/ drivers/ drivers/ +4 more | +10 | 0 replies | Applied |
| 24/24 | MAINTAINERS: move memory balloon infrastructure to "MEMORY MANAGEMENT - BALLOON"MAINTAINERS | +11 | 0 replies | Applied |
Reviews trailers per patch
23 of 24 patches have a Reviewed-by or Acked-by.
| Patch | SeongJae Park | Lorenzo Stoakes | Michael S. Tsirkin | Liam R. Howlett | Vlastimil Babka |
|---|---|---|---|---|---|
| 1/24 | R-b | R-b | A-b | ||
| 2/24 | R-b | A-b | |||
| 3/24 | R-b | A-b | |||
| 4/24 | |||||
| 5/24 | A-b | ||||
| 6/24 | A-b | A-b | |||
| 7/24 | R-b | A-b | |||
| 8/24 | A-b | ||||
| 9/24 | A-b | ||||
| 10/24 | R-b | A-b | |||
| 11/24 | R-b | A-b | |||
| 12/24 | R-b | A-b | |||
| 13/24 | R-b | A-b | |||
| 14/24 | R-b | A-b | |||
| 15/24 | R-b | A-b | |||
| 16/24 | R-b | A-b | |||
| 17/24 | R-b | A-b | |||
| 18/24 | R-b | A-b | |||
| 19/24 | R-b | A-b | |||
| 20/24 | R-b | A-b | |||
| 21/24 | R-b | A-b | |||
| 22/24 | R-b | A-b | |||
| 23/24 | R-b | A-b | |||
| 24/24 | A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH v3 00/24] mm: balloon infrastructure cleanups
I started with wanting to remove the dependency of the balloon infrastructure on the page lock, but ended up performing various other cleanups, some of which I had on my todo list for years.
This series heavily cleans up and simplifies our balloon infrastructure, including our balloon page migration functionality.
With this series, we no longer make use of the page lock for PageOffline pages as part of the balloon infrastructure (preparing for memdescs where PageOffline pages won't have any such lock), and simplifies migration handling such that refcounting can more easily be adjusted later (long-term focus is for PageOffline pages to not have a refcount either).
Plenty of related cleanups.
Heavily compile-tested and heavily runtime-tested with virtio-balloon. PPC CMM and the VMware balloon are untested and I'd appreciate a helping hand from people that have suitable environments.
Not CCing maintainers for the vmscan.c and migrate.c change as they are rather trivial and I don't want to patchbomb them.
--
v2 -> v3:
* "mm/balloon_compaction: centralize basic page migration handling" -> Remove newline
-> Talk about "page" instead of "old page"
-> avoid the switch statement
* "mm/balloon_compaction: move internal helpers to balloon_compaction.c" -> No need to carry over the "inline"
* "fixup mm: rename CONFIG_BALLOON_COMPACTION to CONFIG_BALLOON_MIGRATION -> Remove some more "balloon page compaction" thingies
* "MAINTAINERS: move memory balloon infrastructure to "MEMORY MANAGEMENT - BALLOON"
-> CC the virt list and use the proper mail address
* "mm/balloon_compaction: improve comments for WARN_ON_ONCE(!b_dev_info) -> Added
v1 -> v2:
* Rebased to latest mm/mm-unstable without any conflicts
* Minor patch description/subject and comment fixups
* Retested
David Hildenbrand (Red Hat) (24):
vmw_balloon: adjust BALLOON_DEFLATE when deflating while migrating
vmw_balloon: remove vmballoon_compaction_init() powerpc/pseries/cmm: remove cmm_balloon_compaction_init() mm/balloon_compaction: improve comments for WARN_ON_ONCE(!b_dev_info) mm/balloon_compaction: centralize basic page migration handling mm/balloon_compaction: centralize adjust_managed_page_count() handling
vmw_balloon: stop using the balloon_dev_info lock mm/balloon_compaction: use a device-independent balloon (list) lock mm/balloon_compaction: remove dependency on page lock mm/balloon_compaction: make balloon_mops static mm/balloon_compaction: drop fs.h include from balloon_compaction.h drivers/virtio/virtio_balloon: stop using balloon_page_push/pop() mm/balloon_compaction: remove balloon_page_push/pop() mm/balloon_compaction: fold balloon_mapping_gfp_mask() into
balloon_page_alloc()
mm/balloon_compaction: move internal helpers to balloon_compaction.c mm/balloon_compaction: assert that the balloon_pages_lock is held mm/balloon_compaction: mark remaining functions for having proper
kerneldoc
mm/balloon_compaction: remove "extern" from functions mm/vmscan: drop inclusion of balloon_compaction.h
mm: rename balloon_compaction.(c|h) to balloon.(c|h) mm/kconfig: make BALLOON_COMPACTION depend on MIGRATION
mm: rename CONFIG_BALLOON_COMPACTION to CONFIG_BALLOON_MIGRATION
mm: rename CONFIG_MEMORY_BALLOON -> CONFIG_BALLOON
MAINTAINERS: move memory balloon infrastructure to "MEMORY MANAGEMENT
- BALLOON"
.../admin-guide/mm/memory-hotplug.rst | 8 +-
Documentation/core-api/mm-api.rst | 2 +-
MAINTAINERS | 13 +-
arch/powerpc/platforms/pseries/Kconfig | 2 +-
arch/powerpc/platforms/pseries/cmm.c | 53 +----
drivers/misc/Kconfig | 2 +-
drivers/misc/vmw_balloon.c | 105 +++------
drivers/virtio/Kconfig | 2 +-
drivers/virtio/virtio_balloon.c | 64 ++----
include/linux/balloon.h | 77 +++++++
include/linux/balloon_compaction.h | 160 --------------
include/linux/vm_event_item.h | 8 +-
mm/Kconfig | 23 +-
mm/Makefile | 2 +-
mm/{balloon_compaction.c => balloon.c} | 200 ++++++++++++------
mm/memory_hotplug.c | 4 +-
mm/migrate.c | 2 +-
mm/vmscan.c | 1 -
mm/vmstat.c | 8 +-
19 files changed, 319 insertions(+), 417 deletions(-)
create mode 100644 include/linux/balloon.h
delete mode 100644 include/linux/balloon_compaction.h
rename mm/{balloon_compaction.c => balloon.c} (58%)base-commit: f8ed52ac0cfbddff992bb9600941bfe51e1e385a
Signature · 1 line
2.52.0