Skip to content

Update linker scripts to ensure appended device tree is correctly aligned

Tom Rini u-boot 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 45 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10Makefile: Have binary_size_check report only first match of _image_binary_endMakefile+1 -12 replies
2/10arm: Update linker scripts to ensure appended device tree is alignedarch/arm/cpu/arm1136/u-boot-spl.lds arch/arm/cpu/arm926ejs/mxs/u-boot-spl.lds arch/arm/cpu/arm926ejs/sunxi/u-boot-spl.lds +14 more+71 -1535 replies
3/10m68k: Update linker scripts to ensure appended device tree is alignedarch/m68k/cpu/u-boot.lds+10 -90 replies
4/10microblaze: Update linker scripts to ensure appended device tree is alignedarch/microblaze/cpu/u-boot-spl.lds arch/microblaze/cpu/u-boot.lds+7 -22 replies
5/10mips: Update linker scripts to ensure appended device tree is alignedarch/mips/cpu/u-boot-spl.lds arch/mips/cpu/u-boot.lds+8 -21 reply
6/10nios2: Update linker scripts to ensure appended device tree is alignedarch/nios2/cpu/u-boot.lds+3 -11 reply
7/10powerpc: Update linker scripts to ensure appended device tree is alignedarch/powerpc/cpu/mpc83xx/u-boot.lds arch/powerpc/cpu/mpc85xx/u-boot.lds board/cssi/cmpc885/u-boot.lds +1 more+12 -11 reply
8/10riscv: Update linker scripts to ensure appended device tree is alignedarch/riscv/cpu/u-boot-spl.lds arch/riscv/cpu/u-boot.lds+7 -22 replies
9/10sandbox: Update linker scripts to ensure appended device tree is alignedarch/sandbox/cpu/u-boot-spl.lds+4 -00 replies
10/10x86: Update linker scripts to ensure appended device tree is alignedarch/x86/cpu/u-boot-64.lds arch/x86/cpu/u-boot-spl.lds arch/x86/cpu/u-boot.lds+19 -80 replies

Reviews trailers per patch

6 of 10 patches have a Reviewed-by or Acked-by.

PatchLeo Yu-Chi LiangIlias ApalodimasMichal SimekDaniel SchwierzeckChristophe Leroy (CS GROUP)
1/10
2/10R-b T-b
3/10
4/10R-b T-b
5/10R-b
6/10A-b
7/10R-b
8/10R-b R-b
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH 00/10] Update linker scripts to ensure appended device tree is correctly aligned

Hey all,

This series builds on top of what Beleswar Padhi did in [1]. While there's still discussion about the mkimage related parts, the linker portion appears to the reliable path forward. An alternative that I had mentioned before, and was part of previous discussions on this topic[2] is in the end I believe not reliable enough. While we can take an output file and pad it to where we think it needs to be, ultimately the linker needs to place the symbol where we want it and if that isn't where we pad to, we have a different problem. So what this series does (but each commit message elaborates on the arch-specific linker scripts being inconsistent) is make sure the linker script will place the required symbol at 8-byte alignment, and then also use an ASSERT to fail the build if this would not be true due to some unforseen event.

Given the number of platforms which have failure to run right now, I'd like to pick up at least 2/2 of Beleswar's series as well as this series early next week.

[1]: https://lore.kernel.org/u-boot/[email protected]/
[2]: https://source.denx.de/u-boot/u-boot/-/issues/30

Signature · 1 line
Tom