Improvements for IB handling V3
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest10 patches 9 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | drm/amdgpu: fix type for wptr in ring backupdrivers/ | +1 | 1 reply | |
| 2/10 | drm/amdgpu: rename amdgpu_fence_driver_guilty_force_completion()drivers/ drivers/ drivers/ | +6 | 1 reply | |
| 3/10 | drm/amdgpu/job: use GFP_ATOMIC while in gpu resetdrivers/ drivers/ drivers/ +1 more | +13 | 1 reply | |
| 4/10 | drm/amdgpu: switch all IPs to using job for IBsdrivers/ drivers/ drivers/ +19 more | +500 | 1 reply | |
| 5/10 | drm/amdgpu: require a job to schedule an IBdrivers/ drivers/ drivers/ +1 more | +45 | 1 reply | |
| 6/10 | drm/amdgpu: don't call drm_sched_stop/start() in asic resetdrivers/ | +2 | 1 reply | |
| 7/10 | drm/amdgpu: drop drm_sched_increase_karma()drivers/ | +0 | 1 reply | |
| 8/10 | drm/amdgpu: plumb timedout fence through to force completiondrivers/ drivers/ drivers/ +4 more | +47 | 0 replies | |
| 9/10 | drm/amdgpu: simplify VCN reset helperdrivers/ | +13 | 0 replies | |
| 10/10 | drm/amdgpu: rework ring reset backup and reemitdrivers/ drivers/ drivers/ +2 more | +54 | 2 replies |
Reviews trailers per patch
4 of 10 patches have a Reviewed-by or Acked-by.
| Patch | Christian König |
|---|---|
| 1/10 | R-b |
| 2/10 | R-b |
| 3/10 | |
| 4/10 | A-b |
| 5/10 | |
| 6/10 | |
| 7/10 | |
| 8/10 | R-b |
| 9/10 | |
| 10/10 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/10] Improvements for IB handling V3
This set contains a number of bug fixes and cleanups for IB handling that I worked on over the holidays. The first the three patches from V1 are already reviewed, so I didn't include them in V2 or V3.
Patches 1-2:
Standalone fix and cleanup
Patches 3-5:
Removes the direct submit path for IBs and requires that all IB submissions use a job structure. This greatly simplifies the IB submission code. V2 uses GFP_ATOMIC when in reset. V3 sqaushes all of the IP changes into one patch. Not sure there is much value breaking this out per IP.
Patches 6-9:
Improvements for adapter resets. Stop calling drm_sched_stop/start(). Just stop/start the workqueues. I can see why we need this at all. Per queue reset doesn't use this. Stop calling drm_sched_increase_karma() this seems to result in the jobs always getting marked as innocent and prevents the subsequent fix for marking the job as timedout from working. Per queue resets don't call this and they work correctly. Properly set the error on the the timedout fence so user space see it as guilty. These changes also resulted in a small clean up the the VCN reset helper.
Patch 10:
Rework the backup and reemit code for per ring reset so that we can safely reemit repeatedly. This removes the current single reemit limit currently in place. This drops the new proposed reemit framework from V1 and V2 and sticks with saving and restoring the ring content.
Git tree available as well:
https://gitlab.freedesktop.org/agd5f/linux/-/commits/ib_improvements2?ref_type=heads
Alex Deucher (10):
drm/amdgpu: fix type for wptr in ring backup drm/amdgpu: rename amdgpu_fence_driver_guilty_force_completion() drm/amdgpu/job: use GFP_ATOMIC while in gpu reset drm/amdgpu: switch all IPs to using job for IBs drm/amdgpu: require a job to schedule an IB drm/amdgpu: don't call drm_sched_stop/start() in asic reset drm/amdgpu: drop drm_sched_increase_karma() drm/amdgpu: plumb timedout fence through to force completion drm/amdgpu: simplify VCN reset helper
drm/amdgpu: rework ring reset backup and reemit
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 13 +- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 124 +++++++++-------- drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 117 +++++++--------- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 14 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 37 +----- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 26 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 52 +++----- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c | 37 +++--- drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 31 +++-- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 29 ++-- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 29 ++-- drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 29 ++-- drivers/gpu/drm/amd/amdgpu/gfx_v12_1.c | 29 ++-- drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 24 ++-- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 25 ++-- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 139 ++++++++++---------- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 138 +++++++++---------- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c | 26 ++-- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 29 ++-- drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 38 +++--- drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 38 +++--- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 38 +++--- drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 38 +++--- drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 37 +++--- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 36 ++--- drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 36 ++--- drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c | 36 ++--- drivers/gpu/drm/amd/amdgpu/sdma_v7_1.c | 36 ++--- drivers/gpu/drm/amd/amdgpu/si_dma.c | 29 ++-- 36 files changed, 668 insertions(+), 662 deletions(-)
Signature · 1 line
2.52.0