Skip to content

net/rds: RDS-TCP bug fix collection, subset 2: lock contention, state machine bugs, message drops

Allison Henderson linux-rdma netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net/rds: Change return code from rds_send_xmit() when lock is takennet/rds/send.c+2 -20 replies
2/3net/rds: No shortcut out of RDS_CONN_ERRORnet/rds/connection.c net/rds/tcp_listen.c+2 -50 replies
3/3net/rds: rds_tcp_accept_one ought to not discard messagesnet/rds/connection.c net/rds/rds.h net/rds/recv.c +3 more+168 -760 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next v1 0/3] net/rds: RDS-TCP bug fix collection, subset 2: lock contention, state machine bugs, message drops

From: Allison Henderson <[email protected]>

Hi all,

This is subset 2 of the RDS-TCP bug fix collection series I posted last Oct. The greater series aims to correct multiple rds-tcp bugs that can cause dropped or out of sequence messages. I've broken it down into smaller sets to make reviews more manageable.

In this set, we correct a few RDS/TCP connection handling issues, lock contention issues, and message some loss bugs.

The entire set can be viewed in the rfc here:
https://lore.kernel.org/netdev/[email protected]/

Questions, comments, flames appreciated!
Thanks!
Allison

Gerd Rausch (2):
net/rds: No shortcut out of RDS_CONN_ERROR net/rds: rds_tcp_accept_one ought to not discard messages

Håkon Bugge (1):
net/rds: Change return code from rds_send_xmit() when lock is taken

 net/rds/connection.c |   5 ++
 net/rds/rds.h        |  65 +++++++++++++---------
 net/rds/recv.c       |   4 ++
 net/rds/send.c       |   4 +-
 net/rds/tcp.c        |  27 ++++-----
 net/rds/tcp.h        |  22 +++++++-
 net/rds/tcp_listen.c | 128 +++++++++++++++++++++++++++++++------------
 7 files changed, 172 insertions(+), 83 deletions(-)
Signature · 1 line
2.43.0