Skip to content

fsnotify: Independent inode tracking

Jan Kara linux-fsdevel 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest posting 2/20 of 4 patches 0 repliesNew
  2. v3 posting 1/23 patches 4 repliesSuperseded
  3. v23 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches7 repliesSuperseded

Changes in v3 from the cover letter

* Fix fsnotify_unmount_inodes() to safely deal with connectors not holding inode reference
* Add Amir's Reviewed-by tag

Patches in v3 posting 2/2 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

PatchAmir Goldstein
SeriesR-b R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] fsnotify: Independent inode tracking

Hello!

Here is another revision of the patch set implementing independent tracking of inodes that have any notification marks attached through a linked list of mark connectors used for inodes. We then use this list to destroy all inode marks for a superblock during unmount instead of iterating all inodes on a superblock. With this more efficient way of destroying all inode marks we can move this destruction earlier in generic_shutdown_super() before dcache (and sb->s_root in particular) is pruned which fixes races between fsnotify events encoding handles and accessing sb->s_root after generic_shutdown_super() has freed them.

Changes since v2:
* Fix fsnotify_unmount_inodes() to safely deal with connectors not holding inode reference
* Add Amir's Reviewed-by tag

Changes since v1:
* Remove pointless srcu protection when tearing down inode connectors
* Remove FSNOTIFY_CONN_FLAG_TRACKED as it isn't needed
* Use ihold() instead of __iget() as we don't hold inode->i_lock but the connector holds inode ref
* Add Amir's Reviewed-by tags

Honza

Previous versions: