iio: adc: Improve include relevance for some ADCs.
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest11 patches 9 repliesIn review
Patches in v1 No applies recorded yet
Reviews trailers per patch
1 of 11 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Andy Shevchenko | Nuno Sá |
|---|---|---|
| Series | R-b | |
| 1/11 | R-b | |
| 2/11 | ||
| 3/11 | ||
| 4/11 | ||
| 5/11 | ||
| 6/11 | ||
| 7/11 | ||
| 8/11 | ||
| 9/11 | ||
| 10/11 | ||
| 11/11 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/11] iio: adc: Improve include relevance for some ADCs.
From: Jonathan Cameron <[email protected]>
So this is a continuation of experimenting with IWYU to ensure that we follow what I consider best practice in driver by including all headers that are used (subject to some slightly fuzzy rules for some of them standard kernel headers).
I was focusing on cases where kernel.h was included and moving from that to the more specific headers. That partly explains why there were so many headers to add. However, it is also clear that many standard headers (mutex.h for example) were missing from these drivers.
There are a few notes and questions in the individual patch descriptions, typically where I have either decided to ignore a recommendation or conversely have broken things down more finely than IWYU was doing with my config files.
All comments welcome. Whilst I don't consider this particular high priority (much of it was done in a train where I couldn't access my email)m I would like to provide more examples in tree of what I consider to the right way to do things!
Thanks,
Jonathan
Jonathan Cameron (11):
iio: adc: ltc2471: Improve include relevance
iio: adc: ltc2309: Improve include relevance
iio: adc: max1027: Reorder headers into alphabetical order
iio: adc: max1027: Improve include relevance
iio: adc: max11100: Improve include relevance
iio: adc: max11410: Improve relevance of includes
iio: adc: ad4130: Improve include relevance
iio: adc: ad7124: Improve include relevance
iio: adc: ad7124: Replace device.h with more specific includes
iio: adc: ad7192: Put headers in alphabetical order
iio: adc: ad7192: Improve include relevance
drivers/iio/adc/ad4130.c | 22 ++++++++++++++++++---- drivers/iio/adc/ad7124.c | 17 +++++++++++++---- drivers/iio/adc/ad7192.c | 32 +++++++++++++++++++------------- drivers/iio/adc/ltc2309.c | 9 ++++++++- drivers/iio/adc/ltc2471.c | 8 ++++++-- drivers/iio/adc/max1027.c | 18 ++++++++++++++++-- drivers/iio/adc/max11100.c | 11 ++++++++--- drivers/iio/adc/max11410.c | 22 ++++++++++++++++++++-- 8 files changed, 108 insertions(+), 31 deletions(-)
Signature · 1 line
2.52.0