Skip to content

HID: steelseries: clean up functions, move battery request data to structs

Benjamin Wheeler linux-input lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3HID: steelseries: Clean up hid send_report functionsdrivers/hid/hid-steelseries.c+21 -240 replies
2/3HID: steelseries: Add battery request info (byte flags) to device info.drivers/hid/hid-steelseries.c+79 -00 replies
3/3HID: steelseries: Use device data for battery requestsdrivers/hid/hid-steelseries.c+11 -820 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] HID: steelseries: clean up functions, move battery request data to structs

Hi Sriman,
As requested, here are my patches for your v2 of the new driver.

They fix an issue where the Arctis 7 incorrectly shows 100% battery due to submitting an invalid report. They also include some cleanups of a couple functions.

I've tested these by loading the module in a VM, and seeing that the Arctis 7 reads the correct battery % through the Ubuntu desktop.

If these don't fit nicely into your v3, feel free to take what you need out of them, or, once you submit v3, I can re-do my patches and re-submit.

Thanks!

Benjamin Wheeler (3):
HID: steelseries: Clean up hid send_report functions
HID: steelseries: Add battery request info (byte flags) to device
info.
HID: steelseries: Use device data for battery requests

 drivers/hid/hid-steelseries.c | 217 +++++++++++++++++-----------------
 1 file changed, 111 insertions(+), 106 deletions(-)
Signature · 1 line
2.52.0