Skip to content

migration: small cleanup series

Peter Xu qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest24 patches 20 repliesIn review
  2. v110 patches 17 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/24migration: Introduce qemu_savevm_send_* helpersmigration/savevm.c migration/savevm.h+35 -240 replies
2/24migration: Use qemu_savevm_send_header() in qemu_save_device_state()migration/savevm.c+1 -20 replies
3/24migration: Remove one migration_in_colo_state() occurancemigration/savevm.c+1 -30 replies
4/24migration/savevm: Remove SaveStateEntry.is_rammigration/savevm.c+8 -70 replies
5/24migration/colo: Unwrap qemu_savevm_live_state()migration/colo.c migration/savevm.c migration/savevm.h+2 -90 replies
6/24migration: Remove call to send switchover start event in colo/savevmmigration/colo.c migration/savevm.c+0 -31 reply
7/24colo: Forbid VM resume during checkpointingmonitor/qmp-cmds.c+3 -00 replies
8/24migration/colo: Use the RAM iterable helper directlymigration/colo.c+1 -10 replies
9/24migration/colo: Document qemu_fflush(fb)migration/colo.c+4 -21 reply
10/24migration: Drop iterable_only in qemu_savevm_state_complete_precopymigration/migration.c migration/savevm.c migration/savevm.h+7 -90 replies
11/24migration: Drop qemu_file_set_error() when save non-iterable failsmigration/savevm.c+0 -11 reply
12/24migration/colo: Send device states without copying buffermigration/colo.c+2 -11 reply
13/24migration/postcopy: Send device states without copying buffermigration/savevm.c+2 -11 reply
14/24migration: Introduce qemu_savevm_state_end()migration/colo.c migration/savevm.c migration/savevm.h+11 -41 reply
15/24migration: Provide helper for save vm descriptionmigration/savevm.c migration/savevm.h+24 -121 reply
16/24migration: Split qemu_savevm_state_complete_precopy_non_iterable()migration/migration.c migration/savevm.c migration/savevm.h+10 -121 reply
17/24migration: qemu_savevm_state_complete_precopy() take MigrationState*migration/migration.c migration/savevm.c migration/savevm.h+6 -51 reply
18/24migration: Cleanup error propagates in qemu_savevm_state_setup()migration/savevm.c+0 -31 reply
19/24migration: Refactor qemu_savevm_state_setup()migration/migration.c migration/savevm.c migration/savevm.h+46 -203 replies
20/24migration: Introduce qemu_savevm_state_active()migration/savevm.c+27 -361 reply
21/24migration/bg-snapshot: Cleanup error pathsmigration/migration.c+16 -171 reply
22/24migration: Make qemu_savevm_state_non_iterable() take errpmigration/migration.c migration/savevm.c migration/savevm.h+12 -111 reply
23/24migration: Simplify qemu_save_device_state()migration/savevm.c+0 -52 replies
24/24migration/colo/xen: Use generic helpers in qemu_save_device_state()migration/colo.c migration/savevm.c migration/savevm.h+17 -181 reply

Reviews trailers per patch

23 of 24 patches have a Reviewed-by or Acked-by.

PatchFabiano RosasLukas Straub
SeriesT-b
1/24R-b
2/24R-b
3/24R-b
4/24R-b
5/24R-b
6/24R-b
7/24R-b
8/24R-b
9/24R-b
10/24R-b
11/24R-b
12/24R-b
13/24R-b
14/24R-b
15/24R-b
16/24R-b
17/24R-b
18/24R-b
19/24R-b
20/24R-b
21/24R-b
22/24
23/24R-b
24/24R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/24] migration: small cleanup series

CI: https://gitlab.com/peterx/qemu/-/pipelines/2289719627

v1: https://lore.kernel.org/r/[email protected]

This is the v2 of the small cleanup series. It used to be only for COLO, but now for some other things too around dumping vmstates.

The small series growed a little bit, because I wanted to try Fabiano's request to deduplicate qemu_save_device_state() and precopy's similar version to dump non-iterable devices.

Changelog skipped, as too many things added. Old patches should almost the same with R-bs collected, though. I still touched up some small things, though (where I dropped the R-bs).

This should pass the new COLO unit test too, I hope I didn't overlook something once more. Please anyone let me know if it fails.

Comments welcomed, thanks.

Peter Xu (24):
migration: Introduce qemu_savevm_send_* helpers
migration: Use qemu_savevm_send_header() in qemu_save_device_state()
migration: Remove one migration_in_colo_state() occurance migration/savevm: Remove SaveStateEntry.is_ram migration/colo: Unwrap qemu_savevm_live_state()
migration: Remove call to send switchover start event in colo/savevm
colo: Forbid VM resume during checkpointing migration/colo: Use the RAM iterable helper directly migration/colo: Document qemu_fflush(fb)
migration: Drop iterable_only in qemu_savevm_state_complete_precopy
migration: Drop qemu_file_set_error() when save non-iterable fails migration/colo: Send device states without copying buffer migration/postcopy: Send device states without copying buffer
migration: Introduce qemu_savevm_state_end()
migration: Provide helper for save vm description
migration: Split qemu_savevm_state_complete_precopy_non_iterable()
migration: qemu_savevm_state_complete_precopy() take MigrationState*
migration: Cleanup error propagates in qemu_savevm_state_setup()
migration: Refactor qemu_savevm_state_setup()
migration: Introduce qemu_savevm_state_active() migration/bg-snapshot: Cleanup error paths
migration: Make qemu_savevm_state_non_iterable() take errp
migration: Simplify qemu_save_device_state() migration/colo/xen: Use generic helpers in qemu_save_device_state()

 migration/savevm.h    |  18 +--
 migration/colo.c      |  16 ++-
 migration/migration.c |  48 +++----
 migration/savevm.c    | 312 ++++++++++++++++++++++--------------------
 monitor/qmp-cmds.c    |   3 +
 5 files changed, 213 insertions(+), 184 deletions(-)
Signature · 1 line
2.50.1