Skip to content

net: restore the structure of driver-facing qcfg API

Jakub Kicinski netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 9 repliesApplied 6/6

Patches in v1 All 6 applied

#Subject and filesSizeRepliesApplied
1/6eth: bnxt: always set the queue mgmt opsdrivers/net/ethernet/broadcom/bnxt/bnxt.c+5 -13 repliesApplied
2/6net: introduce a trivial netdev_queue_config()drivers/net/ethernet/broadcom/bnxt/bnxt.c include/net/netdev_queues.h net/core/Makefile +1 more+39 -32 repliesApplied
3/6net: move mp->rx_page_size validation to __net_mp_open_rxq()net/core/netdev_rx_queue.c+6 -40 repliesApplied
4/6net: use netdev_queue_config() for mp restartinclude/net/netdev_queues.h net/core/dev.c net/core/netdev_config.c +1 more+37 -394 repliesApplied
5/6net: add queue config validation callbackinclude/net/netdev_queues.h net/core/dev.h net/core/netdev_config.c +1 more+76 -140 repliesApplied
6/6eth: bnxt: plug bnxt_validate_qcfg() into qopsdrivers/net/ethernet/broadcom/bnxt/bnxt.c+6 -50 repliesApplied

Reviews trailers per patch

2 of 6 patches have a Reviewed-by or Acked-by.

PatchDragos TatuleaSubbaraya Sundeep
1/6R-b
2/6
3/6
4/6R-b
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/6] net: restore the structure of driver-facing qcfg API

The goal of qcfg objects is to let us seamlessly support new use cases without modifying all the drivers. We want to pull all the logic of combining configuration supplied via different interfaces into the core and present the drivers with a flat queue-by-queue configuration. Additionally we want to separate the current effective configuration from the user intent (default vs user setting vs memory provider setting).

Restructure the recently added code to re-introduce the pieces that are missing compared to the old RFC:
https://lore.kernel.org/[email protected]
Namely:
- the netdev_queue_config() helper
- queue config validation callback

I hopefully removed all the more "out there" parts of the RFC.

Jakub Kicinski (6):
eth: bnxt: always set the queue mgmt ops
net: introduce a trivial netdev_queue_config()
net: move mp->rx_page_size validation to __net_mp_open_rxq()
net: use netdev_queue_config() for mp restart
net: add queue config validation callback
eth: bnxt: plug bnxt_validate_qcfg() into qops

 net/core/Makefile                         |  1 +
 include/net/netdev_queues.h               | 17 ++++-
 net/core/dev.h                            |  5 ++
 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 23 ++++---
 net/core/dev.c                            | 17 -----
 net/core/netdev_config.c                  | 78 +++++++++++++++++++++++
 net/core/netdev_rx_queue.c                | 60 ++++++++++-------
 7 files changed, 152 insertions(+), 49 deletions(-)
 create mode 100644 net/core/netdev_config.c
Signature · 1 line
2.52.0