Skip to content

net/rds: RDS-TCP state machine and message loss improvements

Allison Henderson linux-kselftest linux-rdma netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 0 repliesApplied 2/2

Change Log from the cover letter

v2
[PATCH v1 1/3] net/rds: Change return code from rds_send_xmit() when lock is taken
- Dropped for further investigation of possible races

Patches in v2 All 2 applied

#Subject and filesSizeRepliesApplied
1/2net/rds: No shortcut out of RDS_CONN_ERRORnet/rds/connection.c net/rds/tcp_listen.c+2 -50 repliesApplied
2/2net/rds: rds_tcp_accept_one ought to not discard messagesnet/rds/connection.c net/rds/rds.h net/rds/recv.c +3 more+169 -760 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH net-next v2 0/2] net/rds: RDS-TCP state machine and message loss improvements

From: Allison Henderson <[email protected]>

Hi all,

This is subset 2 of the larger RDS-TCP patch series I posted last Oct. The greater series aims to correct multiple rds-tcp issues that can cause dropped or out of sequence messages. I've broken it down into smaller sets to make reviews more manageable.

In this set, we correct a few RDS/TCP connection handling issues, and message loss issues.

The entire set can be viewed in the rfc here:
https://lore.kernel.org/netdev/[email protected]/

Questions, comments, flames appreciated!
Thanks!
Allison

Change Log:
v2
[PATCH v1 1/3] net/rds: Change return code from rds_send_xmit() when lock is taken
- Dropped for further investigation of possible races

[PATCH v2 1/2] net/rds: No shortcut out of RDS_CONN_ERROR
- Removed Fixes tag

[PATCH v2 2/2] net/rds: rds_tcp_accept_one ought to not discard messages
- Fixed netdev/checkpatch warnings

Gerd Rausch (2):
net/rds: No shortcut out of RDS_CONN_ERROR net/rds: rds_tcp_accept_one ought to not discard messages

 net/rds/connection.c |   5 ++
 net/rds/rds.h        |  66 +++++++++++++---------
 net/rds/recv.c       |   4 ++
 net/rds/tcp.c        |  27 ++++-----
 net/rds/tcp.h        |  22 +++++++-
 net/rds/tcp_listen.c | 128 +++++++++++++++++++++++++++++++------------
 6 files changed, 171 insertions(+), 81 deletions(-)
Signature · 1 line
2.43.0