Skip to content

migration: Notifier fixes for 11.0

Peter Xu qemu-devel 2 versions – Applied

Status from this message: Queued, let me know if you want to change patch 2.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 3 repliesApplied
  2. v15 patches 12 repliesSuperseded

Changes in v2 from the cover letter

- Collected r-bs / a-bs
- Patch 2: update comment for possible sequence of notifies [Fabiano]

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/5migration: Add a tracepoint for invoking migration notifiersmigration/migration.c migration/trace-events+3 -00 replies
2/5migration: Fix double notification of DONE/FAIL for postcopyinclude/migration/misc.h migration/migration.c ui/spice-core.c+15 -71 reply
3/5migration: Notify migration FAILED before starting VMmigration/migration.c+15 -40 replies
4/5migration: Drop explicit block activation in postcopy fail pathmigration/migration.c+0 -10 replies
5/5migration: Rename MIG_EVENT_PRECOPY_* to MIG_EVENT_*hw/intc/arm_gicv3_kvm.c hw/net/virtio-net.c hw/vfio/cpr-legacy.c +7 more+29 -330 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchFabiano RosasStefan Hajnoczi
1/5R-b A-b
2/5R-b
3/5R-b A-b
4/5R-b A-b
5/5R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] migration: Notifier fixes for 11.0

CI: https://gitlab.com/peterx/qemu/-/pipelines/2287309287

v2:
- Collected r-bs / a-bs
- Patch 2: update comment for possible sequence of notifies [Fabiano]

v1: https://lore.kernel.org/r/[email protected]

Two major goals for this small series:

- Fix postcopy issue where DONE and FAILED notifiers will be invoked twice

- Move FAILED notifier to be before vm_start() if the failure happens during switchover (where we will stop the VM first)

The 2nd goal will be needed by Stefan's ongoing work on block persistent reservations, where a fallback should be required on src to happen before vm_start(). Instead of introducing another FAILED_BEFORE_START, this patchset should make FAILED work instead.

Patch 1 adds a tracepoint for me to verify this fix.

Patch 2-3 are the real changes of above two.

Patch 3-4 are some cleanups alone the context that we can do, hence attached at the end.

More details in commit logs individually. Comments welcomed, thanks.

Peter Xu (5):
migration: Add a tracepoint for invoking migration notifiers
migration: Fix double notification of DONE/FAIL for postcopy
migration: Notify migration FAILED before starting VM
migration: Drop explicit block activation in postcopy fail path
migration: Rename MIG_EVENT_PRECOPY_* to MIG_EVENT_*

 include/migration/misc.h | 20 ++++++++++++--------
 hw/intc/arm_gicv3_kvm.c  |  2 +-
 hw/net/virtio-net.c      |  4 ++--
 hw/vfio/cpr-legacy.c     |  2 +-
 hw/vfio/cpr.c            |  8 ++++----
 hw/vfio/migration.c      |  4 ++--
 migration/cpr-exec.c     |  6 +++---
 migration/migration.c    | 29 ++++++++++++++++++++---------
 net/vhost-vdpa.c         |  4 ++--
 ui/spice-core.c          |  7 ++++---
 migration/trace-events   |  1 +
 11 files changed, 52 insertions(+), 35 deletions(-)
Signature · 1 line
2.50.1