Skip to content

net/intel: optimize for fast-free hint

Bruce Richardson dpdk-dev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 3 repliesIn review
  2. v31 patch 2 repliesSuperseded
  3. v21 patch 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch5 repliesSuperseded

Changes in v4 from the cover letter

* add precursor patch to adjust mbuf pointers so that the DD bit is written to a descriptor with a valid mbuf pointer associated with it.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net/intel: write mbuf for last Tx desc of segmentdrivers/net/intel/common/tx_scalar.h+2 -11 reply
2/2net/intel: optimize for fast-free hintdrivers/net/intel/common/tx.h drivers/net/intel/common/tx_scalar.h+88 -280 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchCiara LoftusMorten Brørup
SeriesSeries-Acked-by
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/2] net/intel: optimize for fast-free hint

When the fast-free hint is provided to the driver we know that the mbufs have refcnt of 1 and are from the same mempool. Therefore, we can optimize a bit for this case even in the scalar path of our drivers.

---
v4:
* add precursor patch to adjust mbuf pointers so that the DD bit is written to a descriptor with a valid mbuf pointer associated with it.

v3:
* used mbuf_raw_free_bulk rather than mempool function directly
* check for fast_free via mp pointer rather than flags
* remove unnecessary prefetches

V2: Fix issues with original submission:
* missed check for NULL mbufs
* fixed issue with freeing directly from sw_ring in scalar path which doesn't work as thats not a flag array of pointers
* fixed missing null assignment in case of large segments for TSO

Bruce Richardson (2):
net/intel: write mbuf for last Tx desc of segment net/intel: optimize for fast-free hint

 drivers/net/intel/common/tx.h        | 21 ++++--
 drivers/net/intel/common/tx_scalar.h | 98 +++++++++++++++++++++-------
 2 files changed, 90 insertions(+), 29 deletions(-)

--
2.53.0