Skip to content

Remove redundant imports of items re-exported from prelude

Gary Guo dri-devel linux-block lkml nouveau rust-for-linux 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 16 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3gpu: nova-core: remove imports available via preludedrivers/gpu/nova-core/firmware/fwsec.rs drivers/gpu/nova-core/firmware/gsp.rs drivers/gpu/nova-core/firmware/riscv.rs +2 more+7 -214 replies
2/3block: rnull: remove imports available via preludedrivers/block/rnull/configfs.rs drivers/block/rnull/rnull.rs+0 -43 replies
3/3samples: rust: remove imports available via preludesamples/rust/rust_driver_auxiliary.rs samples/rust/rust_misc_device.rs samples/rust/rust_print_main.rs+1 -47 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchDanilo KrummrichAlice RyhlGreg Kroah-HartmanAndreas Hindborg
1/3A-b
2/3A-b
3/3A-b R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 0/3] Remove redundant imports of items re-exported from prelude

We had a few occurrence of these redundant imports and up until now they're mostly checked by human reviews.

I have now implemented a new lint in klint, which is able to spot these and advice on using prelude imports instead. It caught a few existing cases that slip through the review. Thus, fix them.

Gary Guo (3):
gpu: nova-core: remove imports available via prelude
block: rnull: remove imports available via prelude
samples: rust: remove imports available via prelude

 drivers/block/rnull/configfs.rs         |  1 -
 drivers/block/rnull/rnull.rs            |  3 ---
 drivers/gpu/nova-core/firmware/fwsec.rs |  1 -
 drivers/gpu/nova-core/firmware/gsp.rs   | 12 +++++-------
 drivers/gpu/nova-core/firmware/riscv.rs |  2 --
 drivers/gpu/nova-core/gsp/sequencer.rs  |  8 +-------
 drivers/gpu/nova-core/sbuffer.rs        |  5 +----
 samples/rust/rust_driver_auxiliary.rs   |  1 -
 samples/rust/rust_misc_device.rs        |  2 --
 samples/rust/rust_print_main.rs         |  2 +-
 10 files changed, 8 insertions(+), 29 deletions(-)

base-commit: a0c666c25aeefd16f4b088c6549a6fb6b65a8a1d

Signature · 1 line
2.51.2