staging: rtl8723bs: cleanup and refactorcleanup and indentation refactoring
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest7 patches 3 repliesIn review
- v42 patches 1 replySuperseded
- v32 patches 2 repliesSuperseded
Changes in v5 from the cover letter
- Split the series into 7 atomic patches for easier review.
- Renamed "guard clauses" to "continue statements" description per feedback.
- Separated logic changes, comment refactoring, and style cleanups.
- Fixed indentation issues (replaced spaces with tabs).
- Simplified NULL pointer checks to use the !ptr convention.
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | staging: rtl8723bs: use continue statements to reduce indentationdrivers/ | +25 | 2 replies | |
| 2/7 | staging: rtl8723bs: refactor comments to fix the line length warning for exceeding 100 columnsdrivers/ | +5 | 0 replies | |
| 3/7 | staging: rtl8723bs: remove unnecessary new linesdrivers/ | +0 | 0 replies | |
| 4/7 | staging: rtl8723bs: Fix the line length exceeding 100 columns warning in the codedrivers/ | +30 | 0 replies | |
| 5/7 | staging: rtl8723bs: add missing space around operatorsdrivers/ | +7 | 0 replies | |
| 6/7 | staging: rtl8723bs: remove unnecessary bracesdrivers/ | +2 | 0 replies | |
| 7/7 | staging: rtl8723bs: use !ptr instead of ptr == NULLdrivers/ | +1 | 0 replies |
Reviews trailers per patch
None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Dan Carpenter |
|---|---|
| Series | R-b |
| 1/7 | |
| 2/7 | |
| 3/7 | |
| 4/7 | |
| 5/7 | |
| 6/7 | |
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 0/7] staging: rtl8723bs: cleanup and refactorcleanup and indentation refactoring
This series refactors the function in rtw_mlme_ext.c to improve readability and comply with Linux kernel coding standards.
Following feedback from Dan Carpenter, this version (v5) deconstructs the previous changes into seven atomic patches. This separation ensures that logical changes (such as flattening nested loops) are isolated from purely stylistic cleanups (such as fixing indentation or NULL checks), making the review process more straightforward and less error-prone.
Each patch focuses on a single category of improvement:
1. Logic flattening: Use continue statements to reduce indentation.
2. Comment positioning: Adjust comments to align with new logic.
3. New lines cleanup: Removed unnecessary new lines
4. Line length compliance: Resolve 100-column limit warnings.
5. Operator spacing: Add missing spaces around logical operators.
6. Braces removal: Clean up unnecessary braces in single-line branches.
7. NULL check simplification: Use the "!ptr" convention for brevity.
---
Changes in v5:
- Split the series into 7 atomic patches for easier review.
- Renamed "guard clauses" to "continue statements" description per feedback.
- Separated logic changes, comment refactoring, and style cleanups.
- Fixed indentation issues (replaced spaces with tabs).
- Simplified NULL pointer checks to use the !ptr convention.
Changes in v4:
- Corrected the patch format by moving the changelog below the "---" line.
- Initial clean public submission of this series.
Michael Huang (7):
staging: rtl8723bs: use continue statements to reduce indentation
staging: rtl8723bs: refactor comments to fix the line length warning
for exceeding 100 columns
staging: rtl8723bs: remove unnecessary new lines
staging: rtl8723bs: Fix the line length exceeding 100 columns warning
in the code
staging: rtl8723bs: add missing space around operators
staging: rtl8723bs: remove unnecessary braces
staging: rtl8723bs: use !ptr instead of ptr == NULL
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 129 ++++++++++-------- 1 file changed, 70 insertions(+), 59 deletions(-)
--
2.43.0