Skip to content

net: usb: adhere to style by removing typedefs

Ethan Nelson-Moore linux-usb netdev 1 version NAK

Status from this message: NACKED-BY: Oliver Neukum <[email protected]>

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 7 repliesNAK

Patches in v1

#Subject and filesSizeRepliesApplied
1/3net: usb: rtl8150: remove rtl8150_t typedef for struct rtl8150drivers/net/usb/rtl8150.c+33 -352 replies
2/3net: usb: pegasus: remove pegasus_t typedef for struct pegasusdrivers/net/usb/pegasus.c drivers/net/usb/pegasus.h+48 -480 replies
3/3net: usb: kaweth: remove eth_addr_t typedef and bcast_addr definitiondrivers/net/usb/kaweth.c+3 -85 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by.

PatchOliver Neukum
1/3
2/3
3/3NACKED-BY

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/3] net: usb: adhere to style by removing typedefs

It violates kernel code style guidelines to define typedefs for non-opaque types. Update the USB network drivers to conform to these guidelines by expanding such typedefs in their code. Also make small style improvements to code modified in the process.

Ethan Nelson-Moore (3):
net: usb: rtl8150: remove rtl8150_t typedef for struct rtl8150
net: usb: pegasus: remove pegasus_t typedef for struct pegasus
net: usb: kaweth: remove eth_addr_t typedef and bcast_addr definition

 drivers/net/usb/kaweth.c  | 11 ++---
 drivers/net/usb/pegasus.c | 92 +++++++++++++++++++--------------------
 drivers/net/usb/pegasus.h |  4 +-
 drivers/net/usb/rtl8150.c | 68 ++++++++++++++---------------
 4 files changed, 84 insertions(+), 91 deletions(-)
Signature · 1 line
2.43.0