net/pcap: bug fixes and new features
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v25 Latest24 patches 1 replyIn review
- v24 posting 2/224 patches 0 repliesSuperseded
- v24 posting 1/210 of 24 patches 0 repliesSuperseded
Earlier versions · 19
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v23 | 24 patches | 0 replies | Superseded | |
| v22 | 24 patches | 0 replies | Superseded | |
| v21 | 25 patches | 0 replies | Superseded | |
| v20 | 25 patches | 40 replies | Superseded | |
| v19 posting 2/2 | 25 patches | 0 replies | Superseded | |
| v19 posting 1/2 | 0 of 24 patches | 0 replies | Superseded | |
| v18 | 23 patches | 2 replies | Superseded | |
| v17 | 23 patches | 0 replies | Superseded | |
| v16 | 21 patches | 0 replies | Superseded | |
| v15 | 18 patches | 1 reply | Superseded | |
| v14 | 18 patches | 0 replies | Superseded | |
| v13 | 16 patches | 2 replies | Superseded | |
| v12 | 19 patches | 0 replies | Superseded | |
| v11 | 19 patches | 0 replies | Superseded | |
| v10 | 19 patches | 0 replies | Superseded | |
| v9 | 15 patches | 0 replies | Superseded | |
| v8 | 14 patches | 0 replies | Superseded | |
| v7 | 13 patches | 0 replies | Superseded | |
| v6 | 13 patches | 0 replies | Superseded |
Patches in v25 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/24 | maintainers: update for pcap driverMAINTAINERS | +1 | 0 replies | |
| 2/24 | net/pcap: fix build on Windowsdrivers/ | +4 | 0 replies | |
| 3/24 | doc: update features for PCAP PMDdoc/ | +7 | 0 replies | |
| 4/24 | net/pcap: include used headersdrivers/ drivers/ | +9 | 0 replies | |
| 5/24 | net/pcap: remove unnecessary castsdrivers/ | +6 | 0 replies | |
| 6/24 | net/pcap: avoid using rte_malloc and rte_memcpydrivers/ drivers/ drivers/ | +10 | 0 replies | |
| 7/24 | net/pcap: advertise Tx multi segmentdrivers/ | +1 | 0 replies | |
| 8/24 | net/pcap: replace stack bounce bufferdrivers/ | +37 | 0 replies | |
| 9/24 | net/pcap: fix error accounting and backpressure on transmitdrivers/ | +22 | 0 replies | |
| 10/24 | net/pcap: clean up TX dumper return value and typesdrivers/ | +11 | 0 replies | |
| 11/24 | net/pcap: add datapath debug loggingdrivers/ drivers/ | +15 | 0 replies | |
| 12/24 | net/pcap: consolidate boolean flag handlingdrivers/ | +29 | 0 replies | |
| 13/24 | net/pcap: support VLAN strip and insert offloadsdoc/ doc/ doc/ +1 more | +132 | 0 replies | |
| 14/24 | net/pcap: add link status for interface modedoc/ drivers/ drivers/ +3 more | +154 | 0 replies | |
| 15/24 | net/pcap: support nanosecond timestamp precisiondoc/ doc/ drivers/ | +130 | 0 replies | |
| 16/24 | net/pcap: reject non-Ethernet interfacesdrivers/ | +11 | 0 replies | |
| 17/24 | net/pcap: reduce scope of file-level variablesdrivers/ | +4 | 0 replies | |
| 18/24 | net/pcap: clarify maximum received packetdrivers/ | +2 | 0 replies | |
| 19/24 | eal/windows: add wrapper for access functionlib/ lib/ | +8 | 0 replies | |
| 20/24 | net/pcap: add snapshot length devargdoc/ doc/ drivers/ | +154 | 0 replies | |
| 21/24 | net/pcap: add Rx scatter offloaddrivers/ | +45 | 0 replies | |
| 22/24 | net/pcap: add link status change support for iface modedoc/ doc/ doc/ +1 more | +52 | 0 replies | |
| 23/24 | net/pcap: add EOF notification via link status changedoc/ doc/ drivers/ | +91 | 0 replies | |
| 24/24 | test: add comprehensive test suite for pcap PMDapp/ app/ doc/ | +3455 | 0 replies |
Reviews trailers per patch
12 of 24 patches have a Reviewed-by or Acked-by.
| Patch | Bruce Richardson | Chengwen Feng | David Marchand | Marat Khalili |
|---|---|---|---|---|
| 1/24 | A-b | |||
| 2/24 | A-b | A-b | ||
| 3/24 | A-b | |||
| 4/24 | A-b | |||
| 5/24 | ||||
| 6/24 | ||||
| 7/24 | A-b | |||
| 8/24 | A-b | |||
| 9/24 | ||||
| 10/24 | ||||
| 11/24 | ||||
| 12/24 | A-b | |||
| 13/24 | ||||
| 14/24 | ||||
| 15/24 | ||||
| 16/24 | ||||
| 17/24 | A-b | A-b | ||
| 18/24 | A-b | |||
| 19/24 | A-b | |||
| 20/24 | A-b | |||
| 21/24 | A-b | |||
| 22/24 | ||||
| 23/24 | ||||
| 24/24 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v25 00/24] net/pcap: bug fixes and new features
This series contains improvements to the PCAP PMD including new features, bug fixes, code cleanup, and a comprehensive test suite.
New features:
- Nanosecond precision timestamps (when libpcap supports it)
- VLAN tag support
- Link state reporting in interface mode
- Link status change (LSC) interrupt support in interface mode
- EOF notification via link status change for rx_pcap mode
- Advertise RTE_ETH_TX_OFFLOAD_MULTI_SEGS capability
- Configurable snapshot length via snaplen devarg
- Rx scatter offload support with mbuf pool validation
Bug fixes:
- Fix build on Windows from RTE_LOG_LINE changes.
- Fix multi-segment transmit to dynamically allocate instead of silently truncating packets larger than 9K stack buffer
- Fix Tx burst error handling: distinguish malformed mbufs (counted as errors) from pcap_sendpacket backpressure (break and retry)
- Reject non-Ethernet interfaces to prevent malformed packets and kernel warnings on FreeBSD/macOS loopback
Code cleanup:
- Convert internal flags from int to bool
- Remove unnecessary casts of void* from rte_zmalloc
- Replace rte_malloc/rte_memcpy with libc equivalents in osdep code
- Include headers explicitly rather than relying on indirect includes
- Reduce scope of file-level variables
Testing:
- Add comprehensive unit test suite
- Make test suite packet generator handle larger packets
v25 - fix build on one intermediate step for bisectability
v24 - fix format string warning in test code.
Stephen Hemminger (24):
maintainers: update for pcap driver
net/pcap: fix build on Windows
doc: update features for PCAP PMD
net/pcap: include used headers
net/pcap: remove unnecessary casts
net/pcap: avoid using rte_malloc and rte_memcpy net/pcap: advertise Tx multi segment
net/pcap: replace stack bounce buffer
net/pcap: fix error accounting and backpressure on transmit net/pcap: clean up TX dumper return value and types net/pcap: add datapath debug logging
net/pcap: consolidate boolean flag handling net/pcap: support VLAN strip and insert offloads net/pcap: add link status for interface mode net/pcap: support nanosecond timestamp precision net/pcap: reject non-Ethernet interfaces net/pcap: reduce scope of file-level variables net/pcap: clarify maximum received packet eal/windows: add wrapper for access function net/pcap: add snapshot length devarg
net/pcap: add Rx scatter offload
net/pcap: add link status change support for iface mode net/pcap: add EOF notification via link status change
test: add comprehensive test suite for pcap PMD
MAINTAINERS | 1 + app/test/meson.build | 2 + app/test/test_pmd_pcap.c | 3452 ++++++++++++++++++++++++ doc/guides/nics/features/pcap.ini | 9 + doc/guides/nics/pcap.rst | 47 + doc/guides/rel_notes/release_26_07.rst | 12 + drivers/net/pcap/pcap_ethdev.c | 859 ++++-- drivers/net/pcap/pcap_osdep.h | 27 + drivers/net/pcap/pcap_osdep_freebsd.c | 43 +- drivers/net/pcap/pcap_osdep_linux.c | 33 +- drivers/net/pcap/pcap_osdep_windows.c | 76 +- lib/eal/windows/include/rte_os_shim.h | 1 + lib/eal/windows/include/unistd.h | 7 + 13 files changed, 4354 insertions(+), 215 deletions(-) create mode 100644 app/test/test_pmd_pcap.c
Signature · 1 line
2.53.0