ceph: Properly clean up after failures in ceph_submit_write()
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | ceph: free page array when ceph_submit_write() failsfs/ | +8 | 4 replies | |
| 2/2 | ceph: split out page-array discarding to a functionfs/ | +38 | 0 replies |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by.
| Patch | Viacheslav Dubeyko |
|---|---|
| 1/2 | |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] ceph: Properly clean up after failures in ceph_submit_write()
Hi list,
This series contains two patches from my previous series [1] that are independent and have no outstanding review comments.
The patches fix a crash that can occur if ceph_inc_osd_stopping_blocker() fails on write, and split out the complex page-array cleanup logic to a new helper function (per Slava's suggestion). The first patch is intended for stable.
There is no known reproducer for this race condition; it appears to be timing-sensitive. I have a fault-injection patch that can trigger it, which I can provide on request.
Warm regards,
Sam
[1] https://lore.kernel.org/all/[email protected]/
Sam Edwards (2):
ceph: free page array when ceph_submit_write() fails
ceph: split out page-array discarding to a function
fs/ceph/addr.c | 59 ++++++++++++++++++++++++++++++++------------------ 1 file changed, 38 insertions(+), 21 deletions(-)
Signature · 1 line
2.52.0