Skip to content

drm/amd/display: Add support for external DP bridge encoders in DC

Timur Kristóf amd-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14drm/amd/display: Use DCE 6 link encoder for DCE 6 analog connectorsdrivers/gpu/drm/amd/display/dc/resource/dce60/dce60_resource.c+1 -10 replies
2/14drm/amd/display: Only use analog link encoder with analog enginedrivers/gpu/drm/amd/display/dc/resource/dce100/dce100_resource.c drivers/gpu/drm/amd/display/dc/resource/dce60/dce60_resource.c drivers/gpu/drm/amd/display/dc/resource/dce80/dce80_resource.c+6 -30 replies
3/14drm/amd/display: Only use analog stream encoder with analog enginedrivers/gpu/drm/amd/display/dc/resource/dce100/dce100_resource.c+4 -10 replies
4/14drm/amd/display: Add color depth helper function to BIOS parserdrivers/gpu/drm/amd/display/dc/bios/command_table.c+26 -750 replies
5/14drm/amd/display: Refactor DAC load detection, move to HWSSdrivers/gpu/drm/amd/display/dc/bios/bios_parser.c drivers/gpu/drm/amd/display/dc/dc_bios_types.h drivers/gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c +2 more+28 -381 reply
6/14drm/amd/display: Implement BIOS parser external encoder controldrivers/gpu/drm/amd/display/dc/bios/bios_parser.c drivers/gpu/drm/amd/display/dc/bios/command_table.c drivers/gpu/drm/amd/display/dc/dc_bios_types.h +1 more+30 -120 replies
7/14drm/amd/display: Implement DDC probe over AUX channeldrivers/gpu/drm/amd/display/dc/link/link_detection.c+8 -11 reply
8/14drm/amd/display: Add ability for HWSS to prepare the DDC before usedrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c drivers/gpu/drm/amd/display/dc/hwss/hw_sequencer.h drivers/gpu/drm/amd/display/dc/link/link_detection.c+7 -00 replies
9/14drm/amd/display: Use preferred DP link rate if specifieddrivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c+2 -00 replies
10/14drm/amd/display: Add DCE HWSS support for external DP bridge encodersdrivers/gpu/drm/amd/display/dc/dc.h drivers/gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c+58 -00 replies
11/14drm/amd/display: Link detection for external DP bridge encodersdrivers/gpu/drm/amd/display/dc/link/link_detection.c drivers/gpu/drm/amd/display/dc/link/protocols/link_edp_panel_control.c+14 -140 replies
12/14drm/amd/display: Use external DP bridge encodersdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c drivers/gpu/drm/amd/display/dc/link/link_factory.c+35 -30 replies
13/14drm/amd/display: Implement DAC load detection on external DP bridge encodersdrivers/gpu/drm/amd/display/dc/bios/bios_parser.c drivers/gpu/drm/amd/display/dc/dc_bios_types.h drivers/gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c+14 -30 replies
14/14drm/amdgpu: Use DC by default on CIK APUsdrivers/gpu/drm/amd/amdgpu/amdgpu_device.c+0 -110 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/14] drm/amd/display: Add support for external DP bridge encoders in DC

Some GPUs use external DP bridge encoders NUTMEG and TRAVIS to implement analog and/or LVDS connections. Typically found in CIK APU based laptops or on FM2 motherboards that have analog connectors. These were necessary at the time because Kaveri didn't have a built-in DAC nor LVDS support.

These devices sadly don't work transparently and need to be controlled by the driver. This series implements that.

The first half of the series contains some minor fixes and refactoring necessary for these external encoders to work. The second half then adds the actual external encoder support.

When we query connector information from the VBIOS and discover a connector using such an encoder, let's find the real DisplayPort encoder and use that. Set the connector signal type to DP, so the pre-existing DP code paths can work with it without refactoring every signal type check in the DC code base.

With that, we can now enable DC by default on CIK APUs too. DC brings proper support for DP/HDMI audio, DP MST, VRR, 10-bit colors, some HDR features, atomic modesetting, etc. without any loss of functionality.

Timur Kristóf (14):
drm/amd/display: Use DCE 6 link encoder for DCE 6 analog connectors drm/amd/display: Only use analog link encoder with analog engine drm/amd/display: Only use analog stream encoder with analog engine drm/amd/display: Add color depth helper function to BIOS parser drm/amd/display: Refactor DAC load detection, move to HWSS drm/amd/display: Implement BIOS parser external encoder control drm/amd/display: Implement DDC probe over AUX channel drm/amd/display: Add ability for HWSS to prepare the DDC before use drm/amd/display: Use preferred DP link rate if specified drm/amd/display: Add DCE HWSS support for external DP bridge encoders drm/amd/display: Link detection for external DP bridge encoders drm/amd/display: Use external DP bridge encoders drm/amd/display: Implement DAC load detection on external DP bridge
encoders
drm/amdgpu: Use DC by default on CIK APUs

 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    |  11 --
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |   9 +-
 .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c |   3 +
 .../gpu/drm/amd/display/dc/bios/bios_parser.c |  46 +++++--
 .../drm/amd/display/dc/bios/command_table.c   | 124 ++++++------------
 drivers/gpu/drm/amd/display/dc/dc.h           |   4 +
 .../gpu/drm/amd/display/dc/dc_bios_types.h    |   6 +-
 .../amd/display/dc/hwss/dce110/dce110_hwseq.c |  67 ++++++++++
 .../drm/amd/display/dc/hwss/hw_sequencer.h    |   2 +
 .../drm/amd/display/dc/link/link_detection.c  |  56 ++++----
 .../drm/amd/display/dc/link/link_factory.c    |  29 +++-
 .../dc/link/protocols/link_dp_capability.c    |   2 +
 .../link/protocols/link_edp_panel_control.c   |   8 +-
 .../dc/resource/dce100/dce100_resource.c      |   8 +-
 .../dc/resource/dce60/dce60_resource.c        |   5 +-
 .../dc/resource/dce80/dce80_resource.c        |   3 +-
 .../amd/display/include/bios_parser_types.h   |   2 +
 17 files changed, 228 insertions(+), 157 deletions(-)
Signature · 1 line
2.52.0