Skip to content

regulator: qcom-rpmh: Add off-on-delay support

Saikiran linux-arm-msm linux-devicetree lkml 3 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 19 repliesIn review
  2. v21 patch 6 repliesSuperseded
  3. v11 patch 3 repliesSuperseded

Changes in v3 from the cover letter

- Added Patch 1/2: Update DT bindings to allow regulator-off-on-delay-us for qcom,rpmh-regulator (Requested by Mark Brown).
- Updated Patch 2/2: Refined commit message to explicitly mention the passive discharge and bulk capacitor mechanism on the Yoga Slim 7x (Requested by Mark Brown).

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2dt-bindings: regulator: qcom,rpmh: Allow regulator-off-on-delay-usDocumentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml+4 -08 replies
2/2regulator: qcom-rpmh: Add support for regulator-off-on-delay-usdrivers/regulator/qcom-rpmh-regulator.c+3 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/2] regulator: qcom-rpmh: Add off-on-delay support

This series adds support for the standard regulator-off-on-delay-us property to the Qualcomm RPMh regulator driver and updates the corresponding Device Tree bindings.

Motivation:
On the Lenovo Yoga Slim 7x (Snapdragon X Elite), the camera regulators (LDO1, LDO3, LDO7) have large bulk capacitors and rely on passive discharge. When these regulators are disabled, the voltage decays very slowly. If re-enabled too quickly, the sensor experiences a brownout and fails to initialize.

Verification:
I verified that the core drivers/regulator/of_regulator.c does not currently parse regulator-off-on-delay-us in of_get_regulation_constraints(). Therefore, the driver must parse this property explicitly and populate rdesc->off_on_delay so the regulator core can enforce the constraint.

Changes in v3:
- Added Patch 1/2: Update DT bindings to allow regulator-off-on-delay-us for qcom,rpmh-regulator (Requested by Mark Brown).
- Updated Patch 2/2: Refined commit message to explicitly mention the passive discharge and bulk capacitor mechanism on the Yoga Slim 7x (Requested by Mark Brown).

Changes in v2:
- Moved the motivation/context from the cover letter into the commit message of the driver patch.

Saikiran (2):
dt-bindings: regulator: qcom,rpmh: Allow regulator-off-on-delay-us
regulator: qcom-rpmh: Add support for regulator-off-on-delay-us