mm, kvm: allow uffd support in guest_memfd
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest15 patches 14 repliesIn review 9 of 15 applied
- v315 patches 12 repliesSuperseded
- v215 patches 24 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 RFC | 17 patches | 25 replies | Superseded |
Changes in v4 from the cover letter
* fix lock leak not only in patch 4, but also in patch 2, thanks Harry
Patches in v4 9 of 15 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/15 | userfaultfd: introduce mfill_copy_folio_locked() helpermm/ | +35 | 0 replies | Applied |
| 2/15 | userfaultfd: introduce struct mfill_statemm/ | +81 | 1 reply | Applied |
| 3/15 | userfaultfd: introduce mfill_establish_pmd() helpermm/ | +52 | 0 replies | Applied |
| 4/15 | userfaultfd: introduce mfill_get_vma() and mfill_put_vma()mm/ | +75 | 1 reply | Applied |
| 5/15 | userfaultfd: retry copying with locks dropped in mfill_atomic_pte_copy()mm/ | +51 | 1 reply | Applied |
| 6/15 | userfaultfd: move vma_can_userfault out of lineinclude/ mm/ | +35 | 0 replies | Applied |
| 7/15 | userfaultfd: introduce vm_uffd_opsinclude/ include/ mm/ +2 more | +72 | 2 replies | |
| 8/15 | shmem, userfaultfd: use a VMA callback to handle UFFDIO_CONTINUEinclude/ mm/ mm/ | +39 | 0 replies | Applied |
| 9/15 | userfaultfd: introduce vm_uffd_ops->alloc_folio()include/ mm/ | +54 | 0 replies | Applied |
| 10/15 | shmem, userfaultfd: implement shmem uffd operations using vm_uffd_opsinclude/ include/ mm/ +1 more | +106 | 0 replies | Applied |
| 11/15 | userfaultfd: mfill_atomic(): remove retry logicmm/ | +0 | 2 replies | |
| 12/15 | mm: generalize handling of userfaults in __do_fault()mm/ mm/ mm/ | +52 | 0 replies | |
| 13/15 | KVM: guest_memfd: implement userfaultfd operationsmm/ virt/ | +83 | 6 replies | |
| 14/15 | KVM: selftests: test userfaultfd minor for guest_memfdtools/ | +113 | 0 replies | |
| 15/15 | KVM: selftests: test userfaultfd missing for guest_memfdtools/ | +79 | 0 replies |
Reviews trailers per patch
9 of 15 patches have a Reviewed-by or Acked-by.
| Patch | Peter Xu | David Hildenbrand (Arm) | Harry Yoo (Oracle) | Liam R. Howlett | James Houghton |
|---|---|---|---|---|---|
| 1/15 | A-b | R-b | R-b | ||
| 2/15 | A-b | R-b | |||
| 3/15 | R-b | ||||
| 4/15 | R-b | ||||
| 5/15 | R-b | ||||
| 6/15 | R-b | R-b | |||
| 7/15 | |||||
| 8/15 | R-b | ||||
| 9/15 | R-b | ||||
| 10/15 | R-b | ||||
| 11/15 | |||||
| 12/15 | |||||
| 13/15 | |||||
| 14/15 | |||||
| 15/15 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH v4 00/15] mm, kvm: allow uffd support in guest_memfd
From: "Mike Rapoport (Microsoft)" <[email protected]>
Hi,
These patches enable support for userfaultfd in guest_memfd.
As the ground work I refactored userfaultfd handling of PTE-based memory types (anonymous and shmem) and converted them to use vm_uffd_ops for allocating a folio or getting an existing folio from the page cache. shmem also implements callbacks that add a folio to the page cache after the data passed in UFFDIO_COPY was copied and remove the folio from the page cache if page table update fails.
In order for guest_memfd to notify userspace about page faults, there are new VM_FAULT_UFFD_MINOR and VM_FAULT_UFFD_MISSING that a ->fault() handler can return to inform the page fault handler that it needs to call handle_userfault() to complete the fault.
Nikita helped to plumb these new goodies into guest_memfd and provided basic tests to verify that guest_memfd works with userfaultfd.
The handling of UFFDIO_MISSING in guest_memfd requires ability to remove a folio from page cache, the best way I could find was exporting filemap_remove_folio() to KVM.
I deliberately left hugetlb out, at least for the most part. hugetlb handles acquisition of VMA and more importantly establishing of parent page table entry differently than PTE-based memory types. This is a different abstraction level than what vm_uffd_ops provides and people objected to exposing such low level APIs as a part of VMA operations.
Also, to enable uffd in guest_memfd refactoring of hugetlb is not needed and I prefer to delay it until the dust settles after the changes in this set.
v4 changes:
* fix lock leak not only in patch 4, but also in patch 2, thanks Harry
v3: https://lore.kernel.org/all/[email protected]
* add fixes from Harry and Andrei
* fix handling of WP-only mode for WP_ASYNC contexts in vma_can_userfault()
* address David's comments about mfill_get_pmd() and rename it to mfill_establish_pmd()
* add VM_WARN()s for unsupported operations (James)
* update comments using James' suggestions
v2: https://lore.kernel.org/all/[email protected]
* instead of returning uffd-specific values from ->fault() handlers add __do_userfault() helper to resolve user faults in __do_fault()
* address comments from Peter
* rebased on v7.0-c1
RFC: https://lore.kernel.org/all/[email protected]
Mike Rapoport (Microsoft) (11):
userfaultfd: introduce mfill_copy_folio_locked() helper
userfaultfd: introduce struct mfill_state
userfaultfd: introduce mfill_establish_pmd() helper
userfaultfd: introduce mfill_get_vma() and mfill_put_vma()
userfaultfd: retry copying with locks dropped in
mfill_atomic_pte_copy()
userfaultfd: move vma_can_userfault out of line
userfaultfd: introduce vm_uffd_ops
shmem, userfaultfd: use a VMA callback to handle UFFDIO_CONTINUE
userfaultfd: introduce vm_uffd_ops->alloc_folio()
shmem, userfaultfd: implement shmem uffd operations using vm_uffd_ops
userfaultfd: mfill_atomic(): remove retry logic
Nikita Kalyazin (3):
KVM: guest_memfd: implement userfaultfd operations
KVM: selftests: test userfaultfd minor for guest_memfd
KVM: selftests: test userfaultfd missing for guest_memfd
Peter Xu (1):
mm: generalize handling of userfaults in __do_fault()
include/linux/mm.h | 5 + include/linux/shmem_fs.h | 14 - include/linux/userfaultfd_k.h | 73 +- mm/filemap.c | 1 + mm/hugetlb.c | 15 + mm/memory.c | 43 ++ mm/shmem.c | 188 ++--- mm/userfaultfd.c | 694 ++++++++++-------- .../testing/selftests/kvm/guest_memfd_test.c | 191 +++++ virt/kvm/guest_memfd.c | 84 ++- 10 files changed, 860 insertions(+), 448 deletions(-)
base-commit: c369299895a591d96745d6492d4888259b004a9e --
2.53.0