Skip to content

staging: rtl8723bs: remove unused diagnostic

Ethan Tidmore linux-staging lkml oe-kbuild-all 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 2 repliesIn review
  2. v13 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- Expanded the series to include the removal of RX FIFO overflow logic in hal_com.c.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4staging: rtl8723bs: remove dead RX info reset logicdrivers/staging/rtl8723bs/core/rtw_mlme.c+0 -120 replies
2/4staging: rtl8723bs: remove dead RX FIFO overflow logicdrivers/staging/rtl8723bs/hal/hal_com.c drivers/staging/rtl8723bs/hal/rtl8723b_dm.c drivers/staging/rtl8723bs/include/hal_com.h+0 -270 replies
3/4staging: rtl8723bs: remove dead RX sequence logicdrivers/staging/rtl8723bs/core/rtw_recv.c+0 -100 replies
4/4staging: rtl8723bs: remove unused struct debug_priv and all countersdrivers/staging/rtl8723bs/core/rtw_mlme_ext.c drivers/staging/rtl8723bs/core/rtw_pwrctrl.c drivers/staging/rtl8723bs/core/rtw_recv.c +5 more+17 -1200 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/4] staging: rtl8723bs: remove unused diagnostic

This series performs a driver-wide audit and cleanup of dead diagnostic code within the rtl8723bs staging driver.

The vendor-originated code included a variety of diagnostic counters housed within 'struct debug_priv'. These counters were updated throughout the driver's hot paths—including MLME, receive, power control, and SDIO allocation—but were never read, exposed via debugfs, or utilized for any internal logic.

This series removes the write-only counters, the skeletal functions used to update them, and cleans up the resulting unused pointers and logic blocks.

Changes in v2:
- Expanded the series to include the removal of RX FIFO overflow logic in hal_com.c.

Ethan Tidmore (4):
staging: rtl8723bs: remove dead RX info reset logic
staging: rtl8723bs: remove dead RX FIFO overflow logic
staging: rtl8723bs: remove dead RX sequence logic
staging: rtl8723bs: remove unused struct debug_priv and all counters

 drivers/staging/rtl8723bs/core/rtw_mlme.c     | 12 -----
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |  3 --
 drivers/staging/rtl8723bs/core/rtw_pwrctrl.c  |  6 +--
 drivers/staging/rtl8723bs/core/rtw_recv.c     | 23 +--------
 drivers/staging/rtl8723bs/hal/hal_com.c       | 19 --------
 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c   |  7 ---
 .../staging/rtl8723bs/hal/rtl8723b_hal_init.c |  4 --
 drivers/staging/rtl8723bs/hal/sdio_halinit.c  |  8 +---
 drivers/staging/rtl8723bs/include/drv_types.h | 41 ----------------
 drivers/staging/rtl8723bs/include/hal_com.h   |  1 -
 drivers/staging/rtl8723bs/os_dep/os_intfs.c   | 14 ++----
 drivers/staging/rtl8723bs/os_dep/sdio_intf.c  | 48 +++++--------------
 12 files changed, 17 insertions(+), 169 deletions(-)
Signature · 1 line
2.52.0