Skip to content

staging: rtl8723bs: Fix OOB read and perform code clean ups

Luka Gejak linux-staging lkml stable 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest posting 2/25 patches 2 repliesIn review
  2. v6 posting 1/23 of 5 patches 0 repliesSuperseded
  3. v55 patches 4 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v45 patches1 replySuperseded
v35 patches0 repliesSuperseded
v25 patches3 repliesSuperseded
v13 patches2 repliesSuperseded

Changes in v6 from the cover letter

- Fixed an issue where patch subject lines were truncated in the previous submission due to a local formatting error. No logical code changes.

Patches in v6 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5staging: rtl8723bs: fix potential out-of-bounds read in rtw_restruct_wmm_iedrivers/staging/rtl8723bs/core/rtw_mlme.c+4 -12 replies
2/5staging: rtl8723bs: rename u1bTmp to valdrivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c drivers/staging/rtl8723bs/hal/sdio_halinit.c+22 -220 replies
3/5staging: rtl8723bs: fix spacing around operatorsdrivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c drivers/staging/rtl8723bs/hal/sdio_halinit.c+15 -150 replies
4/5staging: rtl8723bs: modernize hex output in rtw_report_sec_iedrivers/staging/rtl8723bs/core/rtw_mlme.c+2 -30 replies
5/5staging: rtl8723bs: remove dead debugging code in rtw_mlme_ext.cdrivers/staging/rtl8723bs/core/rtw_mlme_ext.c+0 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [PATCH v6 0/5] staging: rtl8723bs: Fix OOB read and perform code clean ups

Changes in v6:
- Fixed an issue where patch subject lines were truncated in the previous submission due to a local formatting error. No logical code changes.
Changes in v5:
- Corrected commit message line wrapping to 72 characters.
- Removed blank lines between tags in the Signed-off-by block.
- Removed "Security:" prefix from subject lines.
Changes in v4:
- IMPORTANT: Fixed a build regression in rtw_mlme.c found after submitting v3. v3 will not compile; please use this version instead.
- Fixed build regression in rtw_mlme.c found in v3.
- Removed unused variable 'i' from previous iteration. Changes in v3:
- Reordered the series so the bugfix is Patch 1/5.
- Patch 1: Dropped memcmp change, kept original byte comparison style for clarity (requested by Greg KH).
- Patch 1: Added Cc: stable tag.
- Patch 1: Updated commit message to explain the OOB read logic. Changes in v2:
- Split u1bTmp rename and spacing fixes into two separate patches.
- Split hex modernization and the WMM bugfix into two separate patches.
- Added a Fixes: tag to the WMM bugfix.
- Removed an unused variable and dead debugging code.

Luka Gejak (5):
staging: rtl8723bs: fix potential out-of-bounds read in
rtw_restruct_wmm_ie
staging: rtl8723bs: rename u1bTmp to val
staging: rtl8723bs: fix spacing around operators
staging: rtl8723bs: modernize hex output in rtw_report_sec_ie
staging: rtl8723bs: remove dead debugging code in rtw_mlme_ext.c

 drivers/staging/rtl8723bs/core/rtw_mlme.c     | 10 +++---
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |  9 ------
 .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 32 +++++++++----------
 drivers/staging/rtl8723bs/hal/sdio_halinit.c  | 32 +++++++++----------
 4 files changed, 38 insertions(+), 45 deletions(-)
Signature · 1 line
2.52.0