Skip to content

RFC Introduce HasField infrastructure

Boqun Feng lkml rcu rust-for-linux 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest7 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7rust: types: Introduce HasField trait and derive macrorust/kernel/field.rs rust/kernel/lib.rs rust/kernel/prelude.rs +2 more+173 -10 replies
2/7rust: time: hrtimer: Make `HasField` a super-trait of `HasHrTimer`rust/kernel/time/hrtimer.rs+15 -550 replies
3/7rust: workqueue: Add HasField support for Workrust/kernel/workqueue.rs+38 -220 replies
4/7drivers: android: binder: Replace `impl_has_work!` with `#[derive(HasField)]`drivers/android/binder/process.rs+2 -40 replies
5/7rust: sync: Completion: Replace `impl_has_work!` with `#[derive(HasField)]`rust/kernel/sync/completion.rs+3 -50 replies
6/7rust: work: Remove `impl_has_work!`rust/kernel/workqueue.rs+2 -510 replies
7/7rust: sync: rcu: Introduce RcuHeadrust/kernel/sync/rcu.rs+68 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/7] Introduce HasField infrastructure

Currently we have a few similar places where we use a Has* trait to describe that a data structure has some types of field in it so that the containing type can do something with it. There are also a impl_has_*! macro to help implement the trait. While it's working, but it's less ergonomic to me, especially considering the amount of the work we need to do for something new (e.g. rcu_head).

Therefore here is the effort to unify them into a proc-macro based solution. Field and HasField traits are introduced to generify the "Has A" relationship, and a derive macro #[derive(HasField)] is also added to support automatically implementing HasField trait.

This series convert a few users (Work, HrTimer) and introduce a new Field type RcuHead. These improvements demonstrate how this infrastructure can be used.

Some future work is still needed: using HasField for DelayedWork and ListLink is still missing. Also it's possible to clean up HasWork trait as well.

One known issue is that #[derive(HasField)] doesn't play alone with #[pin_data] at the moment, for example:

    #[derive(HasField)]
    #[pin_data]
    struct Foo { .. }

works, but

    #[pin_data]
    #[derive(HasField)]
    struct Foo { .. }

doesn't. Maybe it's by design or maybe something could be improved by pin-init.

The patchset is based on today's rust/rust-next, top commit is:

a7c013f77953 ('Merge patch series "refactor Rust proc macros with syn"')

Regards,
Boqun

Boqun Feng (7):
rust: types: Introduce HasField trait and derive macro
rust: time: hrtimer: Make HasField a super-trait of HasHrTimer
rust: workqueue: Add HasField support for Work
drivers: android: binder: Replace impl_has_work! with

    `#[derive(HasField)]`
  rust: sync: Completion: Replace `impl_has_work!` with
    `#[derive(HasField)]`

rust: work: Remove impl_has_work!
rust: sync: rcu: Introduce RcuHead

 drivers/android/binder/process.rs |   6 +-
 rust/kernel/field.rs              |  73 ++++++++++++++++++++
 rust/kernel/lib.rs                |   1 +
 rust/kernel/prelude.rs            |   4 +-
 rust/kernel/sync/completion.rs    |   8 +--
 rust/kernel/sync/rcu.rs           |  69 ++++++++++++++++++-
 rust/kernel/time/hrtimer.rs       |  70 ++++---------------
 rust/kernel/workqueue.rs          | 109 +++++++++++-------------------
 rust/macros/field.rs              |  85 +++++++++++++++++++++++
 rust/macros/lib.rs                |  11 +++
 10 files changed, 299 insertions(+), 137 deletions(-)
 create mode 100644 rust/kernel/field.rs
 create mode 100644 rust/macros/field.rs
Signature · 1 line
2.50.1 (Apple Git-155)