Skip to content

ublk: misc improvement in driver and selftests

Ming Lei linux-block 2 versions Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 3 repliesApplied
  2. v15 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- add selftests: ublk: move test temp files into a sub directory for avoiding conflict
- avoid wq schedule for UBLK_F_NO_AUTO_PART_SCAN(Caleb Sander Mateos)
- avoid sed in retrieving TID (Alexander Atanasov)
- commit log typo fix on 2nd patch(Alexander Atanasov)
- more ublk selftests improvement:
- rename test_generic_15 to test_part_02
- refactor test_null_04 into separate functions and simplifying implementations
- kill IO failure in null/integrity tests by not scanning partition

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/9ublk: check list membership before cancelling batch fetch commanddrivers/block/ublk_drv.c+13 -30 replies
2/9ublk: add UBLK_F_NO_AUTO_PART_SCAN feature flagdrivers/block/ublk_drv.c include/uapi/linux/ublk_cmd.h+13 -40 replies
3/9selftests: ublk: derive TID automatically from script nametools/testing/selftests/ublk/test_batch_01.sh tools/testing/selftests/ublk/test_batch_02.sh tools/testing/selftests/ublk/test_batch_03.sh +44 more+5 -460 replies
4/9selftests: ublk: add selftest for UBLK_F_NO_AUTO_PART_SCANtools/testing/selftests/ublk/Makefile tools/testing/selftests/ublk/kublk.c tools/testing/selftests/ublk/kublk.h +1 more+113 -20 replies
5/9selftests: ublk: rename test_generic_15 to test_part_02tools/testing/selftests/ublk/Makefile tools/testing/selftests/ublk/test_part_02.sh+1 -10 replies
6/9selftests: ublk: refactor test_null_04 into separate functionstools/testing/selftests/ublk/test_null_04.sh+94 -1540 replies
7/9selftests: ublk: disable partition scan for integrity teststools/testing/selftests/ublk/test_null_04.sh+4 -40 replies
8/9selftests: ublk: mark each test start and end time in dmesgtools/testing/selftests/ublk/test_common.sh+2 -00 replies
9/9selftests: ublk: move test temp files into a sub directorytools/testing/selftests/ublk/test_common.sh+8 -32 replies

Reviews trailers per patch

1 of 9 patches has a Reviewed-by or Acked-by.

PatchCaleb Sander Mateos
1/9
2/9
3/9R-b
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH V2 0/9] ublk: misc improvement in driver and selftests

The 1st patch improves fetch command removal and canceling, which is reported as risk from AI.

The 2nd patch adds UBLK_F_NO_AUTO_PART_SCAN for disabling partition scanning during adding disk.

The other patches improves ublk selftests:
- rename test_generic_15 to test_part_02
- refactor test_null_04 into separate functions and simplifying implementations
- kill IO verify failure in null/integrity tests by not scanning partition
- mark each test start and end in dmesg log
- move all temp files/dir into single directory, and allow user to override default temp dir
- derive TID automatically from script name

V2:
- add selftests: ublk: move test temp files into a sub directory for avoiding conflict
- avoid wq schedule for UBLK_F_NO_AUTO_PART_SCAN(Caleb Sander Mateos)
- avoid sed in retrieving TID (Alexander Atanasov)
- commit log typo fix on 2nd patch(Alexander Atanasov)
- more ublk selftests improvement:
- rename test_generic_15 to test_part_02
- refactor test_null_04 into separate functions and simplifying implementations
- kill IO failure in null/integrity tests by not scanning partition

Alexander Atanasov (2):
selftests: ublk: mark each test start and end time in dmesg
selftests: ublk: move test temp files into a sub directory

Ming Lei (7):
ublk: check list membership before cancelling batch fetch command
ublk: add UBLK_F_NO_AUTO_PART_SCAN feature flag
selftests: ublk: derive TID automatically from script name
selftests: ublk: add selftest for UBLK_F_NO_AUTO_PART_SCAN
selftests: ublk: rename test_generic_15 to test_part_02
selftests: ublk: refactor test_null_04 into separate functions
selftests: ublk: disable partition scan for integrity tests

 drivers/block/ublk_drv.c                      |  30 ++-
 include/uapi/linux/ublk_cmd.h                 |   3 +
 tools/testing/selftests/ublk/Makefile         |   4 +-
 tools/testing/selftests/ublk/kublk.c          |   6 +-
 tools/testing/selftests/ublk/kublk.h          |   3 +-
 tools/testing/selftests/ublk/test_batch_01.sh |   1 -
 tools/testing/selftests/ublk/test_batch_02.sh |   1 -
 tools/testing/selftests/ublk/test_batch_03.sh |   1 -
 tools/testing/selftests/ublk/test_common.sh   |  18 +-
 .../testing/selftests/ublk/test_generic_01.sh |   1 -
 .../testing/selftests/ublk/test_generic_02.sh |   1 -
 .../testing/selftests/ublk/test_generic_03.sh |   1 -
 .../testing/selftests/ublk/test_generic_04.sh |   1 -
 .../testing/selftests/ublk/test_generic_05.sh |   1 -
 .../testing/selftests/ublk/test_generic_06.sh |   1 -
 .../testing/selftests/ublk/test_generic_07.sh |   1 -
 .../testing/selftests/ublk/test_generic_08.sh |   1 -
 .../testing/selftests/ublk/test_generic_09.sh |   1 -
 .../testing/selftests/ublk/test_generic_10.sh |   1 -
 .../testing/selftests/ublk/test_generic_11.sh |   1 -
 .../testing/selftests/ublk/test_generic_12.sh |   1 -
 .../testing/selftests/ublk/test_generic_13.sh |   1 -
 .../testing/selftests/ublk/test_generic_14.sh |   1 -
 .../testing/selftests/ublk/test_generic_16.sh |   1 -
 tools/testing/selftests/ublk/test_loop_01.sh  |   1 -
 tools/testing/selftests/ublk/test_loop_02.sh  |   1 -
 tools/testing/selftests/ublk/test_loop_03.sh  |   1 -
 tools/testing/selftests/ublk/test_loop_04.sh  |   1 -
 tools/testing/selftests/ublk/test_loop_05.sh  |   1 -
 tools/testing/selftests/ublk/test_loop_06.sh  |   1 -
 tools/testing/selftests/ublk/test_loop_07.sh  |   1 -
 tools/testing/selftests/ublk/test_loop_08.sh  |   1 -
 tools/testing/selftests/ublk/test_null_01.sh  |   1 -
 tools/testing/selftests/ublk/test_null_02.sh  |   1 -
 tools/testing/selftests/ublk/test_null_03.sh  |   1 -
 tools/testing/selftests/ublk/test_null_04.sh  | 249 +++++++-----------
 tools/testing/selftests/ublk/test_part_01.sh  | 104 ++++++++
 .../{test_generic_15.sh => test_part_02.sh}   |   1 -
 .../testing/selftests/ublk/test_stress_01.sh  |   1 -
 .../testing/selftests/ublk/test_stress_02.sh  |   1 -
 .../testing/selftests/ublk/test_stress_03.sh  |   1 -
 .../testing/selftests/ublk/test_stress_04.sh  |   1 -
 .../testing/selftests/ublk/test_stress_05.sh  |   1 -
 .../testing/selftests/ublk/test_stress_06.sh  |   1 -
 .../testing/selftests/ublk/test_stress_07.sh  |   1 -
 .../testing/selftests/ublk/test_stress_08.sh  |   1 -
 .../testing/selftests/ublk/test_stress_09.sh  |   1 -
 .../testing/selftests/ublk/test_stripe_01.sh  |   1 -
 .../testing/selftests/ublk/test_stripe_02.sh  |   1 -
 .../testing/selftests/ublk/test_stripe_03.sh  |   1 -
 .../testing/selftests/ublk/test_stripe_04.sh  |   1 -
 .../testing/selftests/ublk/test_stripe_05.sh  |   1 -
 .../testing/selftests/ublk/test_stripe_06.sh  |   1 -
 53 files changed, 249 insertions(+), 213 deletions(-)
 create mode 100755 tools/testing/selftests/ublk/test_part_01.sh
 rename tools/testing/selftests/ublk/{test_generic_15.sh => test_part_02.sh} (99%)
Signature · 1 line
2.47.0