Skip to content

Optimize zone->contiguous update

Tianyou Li linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v9 Latest2 patches 16 repliesIn review

Changes in v9 from the cover letter

1. Separate the bug fix and optimization into two patches.
2. This patchset depends on the https://lore.kernel.org/linux-mm/[email protected]/.
3. Refactor the code to move most of memory_block_online() to
mhp_block_online() and correspondingly memory_block_offline() to
mhp_block_offline().

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2mm/memory hotplug/unplug: Add online_memory_block_pages() and offline_memory_block_pages()drivers/base/memory.c include/linux/memory_hotplug.h include/linux/mm.h +1 more+141 -1250 replies
2/2mm/memory hotplug/unplug: Optimize zone->contiguous update when changes pfn rangemm/internal.h mm/memory_hotplug.c mm/mm_init.c+89 -1416 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchYuan LiuTim ChenQiuxu ZhuoYu C ChenPan DengNanhai Zou
1/2T-b R-b
2/2T-b R-b R-b R-b R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v9 thread

Cover letter [PATCH v9 0/2] Optimize zone->contiguous update

This series contains 2 patches. The first one encapsulate the mhp_init_memmap_on_memory() and online_pages() into online_memory_block_pages(), the mhp_deinit_memmap_on_memory() and offline_pages() into offline_memory_block_pages(). Then move most of memory_block_online() to the new function mhp_block_online(struct memory_block *block) and correspondingly memory_block_offline() to mhp_block_offline(struct memory_block *block). The second one add a fast path to check the zone->contiguous.

Changes History
===============
v9 changes:
1. Separate the bug fix and optimization into two patches.
2. This patchset depends on the https://lore.kernel.org/linux-mm/[email protected]/.
3. Refactor the code to move most of memory_block_online() to
mhp_block_online() and correspondingly memory_block_offline() to
mhp_block_offline().

v8 changes:
1. Rebased to 6.19-rc6
2. Add online_memory_block_pages() and offline_memory_block_pages()

v7 changes:
1. Rebased to 6.19-rc1
2. Reorder the patches so that the fix will be the first in the series.

v6 changes:
1. Improve coding style.
2. Add comments.

v5 changes:
1. Improve coding style.
2. Fix a issue in which zone->contiguous was always false when adding new memory, leveraging the fast path optimization.

v4 changes:
1. Improve coding style.
2. Add fast path for zone contiguity check in memory unplugged cases, and update test results.
3. Refactor set_zone_contiguous: the new set_zone_contiguous updates zone contiguity based on the fast path results.

v3 changes:
Add zone contiguity check for empty zones.

v2 changes:
Add check_zone_contiguous_fast function to check zone contiguity for new memory PFN ranges.

Tianyou Li (2):
mm/memory hotplug/unplug: Add online_memory_block_pages() and
offline_memory_block_pages()
mm/memory hotplug/unplug: Optimize zone->contiguous update when
changes pfn range

 drivers/base/memory.c          | 115 +-----------------
 include/linux/memory_hotplug.h |  13 +--
 include/linux/mm.h             |   6 +
 mm/internal.h                  |   8 +-
 mm/memory_hotplug.c            | 208 ++++++++++++++++++++++++++++++---
 mm/mm_init.c                   |  15 ++-
 6 files changed, 228 insertions(+), 137 deletions(-)
Signature · 1 line
2.47.1