Skip to content

bulk: Stop forward-declaring enum typedefs

Philippe Mathieu-Daudé qemu-devel 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 5 repliesIn review
  2. v12 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Fixed QemuClipboardNotifyType typo
- checkpatch regexp
- Pierrick's R-b

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2bulk: Stop forward-declaring enum typedefshw/core/loader.c hw/display/xlnx_dp.c hw/dma/xlnx_dpdma.c +15 more+50 -855 replies
2/2docs/devel: Mention enum typedefs forward-declaration is not alloweddocs/devel/style.rst scripts/checkpatch.pl+16 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchPierrick Bouvier
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] bulk: Stop forward-declaring enum typedefs

v2:
- Fixed QemuClipboardNotifyType typo
- checkpatch regexp
- Pierrick's R-b

The C99 standard chapter §6.7.2.2 point 4 mentions:

Each enumerated type shall be compatible with char, a signed integer type, or an unsigned integer type. The choice of type is implementation-defined, but shall be capable of representing the values of all the members of the enumeration.

Align with that recommendation by defining the typedef along with the enum.

Philippe Mathieu-Daudé (2):
bulk: Stop forward-declaring enum typedefs
docs/devel: Mention enum typedefs forward-declaration is not allowed

 docs/devel/style.rst                 | 11 +++++++++++
 hw/riscv/riscv-iommu-bits.h          |  4 ++--
 hw/riscv/riscv-iommu.h               |  2 --
 include/hw/misc/auxbus.h             | 11 ++++-------
 include/hw/pci/pci_device.h          |  5 ++---
 include/hw/ssi/ssi.h                 |  6 ++----
 include/hw/xen/interface/io/xenbus.h |  5 ++---
 include/io/channel.h                 | 11 ++++-------
 include/system/replay.h              | 10 ++++------
 include/ui/clipboard.h               | 15 ++++++---------
 include/ui/kbd-state.h               |  6 ++----
 pc-bios/s390-ccw/virtio.h            |  5 ++---
 tests/qtest/libqos/qgraph_internal.h | 10 ++++------
 hw/core/loader.c                     |  5 ++---
 hw/display/xlnx_dp.c                 | 11 ++++-------
 hw/dma/xlnx_dpdma.c                  | 10 ++++------
 qapi/opts-visitor.c                  |  7 ++-----
 qapi/string-output-visitor.c         |  6 ++----
 tests/unit/check-qom-proplist.c      |  6 ++----
 scripts/checkpatch.pl                |  5 +++++
 20 files changed, 66 insertions(+), 85 deletions(-)
Signature · 1 line
2.52.0