nvme: export additional diagnostic counters via sysfs
Status from this message: Thanks, applied to nvme-7.2.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest8 patches 8 repliesApplied
- v37 patches 10 repliesSuperseded
- v27 patches 7 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 7 patches | 6 replies | Superseded |
Changes in v4 from the cover letter
- To be consistent in naming, all counters are suffixed with _count (Keith Busch)
- The first patch in the series creates new attribute group named diag and all counters are now grouped under this new sysfs attribute group (Keith Busch)
- Counters are defined as atomic_long_t instead of size_t (Keith Busch)
- Removed RB and TB tags due to above changes
Link to v3: https://lore.kernel.org/all/[email protected]/
Patches in v4 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | nvme: add diag attribute group under sysfsdrivers/ drivers/ drivers/ | +37 | 0 replies | |
| 2/8 | nvme: export command retry count via sysfsdrivers/ drivers/ drivers/ | +38 | 0 replies | |
| 3/8 | nvme: export multipath failover count via sysfsdrivers/ drivers/ drivers/ | +38 | 0 replies | |
| 4/8 | nvme: export command error counters via sysfsdrivers/ drivers/ drivers/ | +77 | 0 replies | |
| 5/8 | nvme: export I/O requeue count when no path is usable via sysfsdrivers/ drivers/ drivers/ | +37 | 0 replies | |
| 6/8 | nvme: export I/O failure count when no path is available via sysfsdrivers/ drivers/ drivers/ | +37 | 4 replies | |
| 7/8 | nvme: export controller reset event count via sysfsdrivers/ drivers/ drivers/ | +29 | 0 replies | |
| 8/8 | nvme: export controller reconnect event count via sysfsdrivers/ drivers/ drivers/ +2 more | +44 | 0 replies |
Reviews trailers per patch
None of the 8 patches has a Reviewed-by or Acked-by.
| Patch | Venkat Rao Bagalkote |
|---|---|
| Series | T-b |
| 1/8 | |
| 2/8 | |
| 3/8 | |
| 4/8 | |
| 5/8 | |
| 6/8 | |
| 7/8 | |
| 8/8 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCHv4 0/8] nvme: export additional diagnostic counters via sysfs
Hi,
The NVMe driver encounters various events and conditions during normal operation that are either not tracked today or not exposed to userspace via sysfs. Lack of visibility into these events can make it difficult to diagnose subtle issues related to controller behavior, multipath stability, and I/O reliability.
This patchset adds several diagnostic counters that provide improved observability into NVMe behavior. These counters are intended to help users understand events such as transient path unavailability, controller retries/reconnect/reset, failovers, and I/O failures. They can also be consumed by monitoring tools such as nvme-top.
Specifically, this series proposes to export the following counters via sysfs:
- Command retry count
- Multipath failover count
- Command error count
- I/O requeue count
- I/O failure count
- Controller reset event counts
- Controller reconnect counts
The first patch in the series adds a new diag attribute group under per-path, ns-head and ctrl sysfs directories so that all diagnostics counters could be grouped together under diag sub-directory. The subsequent patches in the series adds diagnostics counters listed above.
Please note that this patchset doesn't make any functional change but rather export relevant counters to user space via sysfs.
As usual, feedback/comments/suggestions are welcome!
Changes from v3:
- To be consistent in naming, all counters are suffixed with _count (Keith Busch)
- The first patch in the series creates new attribute group named diag and all counters are now grouped under this new sysfs attribute group (Keith Busch)
- Counters are defined as atomic_long_t instead of size_t (Keith Busch)
- Removed RB and TB tags due to above changes
Link to v3: https://lore.kernel.org/all/[email protected]/
Changes from v2:
- Allow user to write to sysfs attributes so that user could
reset stat counters, if needed (Sagi)
- The controller reconnect counter nr_reconnects could reset
to zero once connection is re-established, so instead of
exposing nr_reconnects counter via sysfs introduce a new
counter which accumulates the reconnect attempts and export
this accumulated counter via sysfs (Sagi)
Link to v2: https://lore.kernel.org/all/[email protected]/
Changes from v1:
- Remove export of stats for admin command rerty count (Keith)
- Use size_add() to ensure stat counters don't overflow (Keith)
Link to v1: https://lore.kernel.org/all/[email protected]/
Nilay Shroff (8):
nvme: add diag attribute group under sysfs
nvme: export command retry count via sysfs
nvme: export multipath failover count via sysfs
nvme: export command error counters via sysfs
nvme: export I/O requeue count when no path is available via sysfs
nvme: export I/O failure count when no path is available via sysfs
nvme: export controller reset event count via sysfs
nvme: export controller reconnect event count via sysfs
drivers/nvme/host/core.c | 15 ++- drivers/nvme/host/fc.c | 3 + drivers/nvme/host/multipath.c | 87 ++++++++++++++ drivers/nvme/host/nvme.h | 13 +++ drivers/nvme/host/pci.c | 1 + drivers/nvme/host/rdma.c | 2 + drivers/nvme/host/sysfs.c | 214 ++++++++++++++++++++++++++++++++++ drivers/nvme/host/tcp.c | 2 + 8 files changed, 336 insertions(+), 1 deletion(-)
Signature · 1 line
2.53.0