selftests: ublk: test infrastructure improvements
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | selftests: ublk: simplify UBLK_TEST_DIR handlingtools/ | +1 | 0 replies | |
| 2/9 | selftests: ublk: refactor test_loop_08 into separate functionstools/ | +115 | 0 replies | |
| 3/9 | selftests: ublk: add _ublk_del_dev helper functiontools/ tools/ tools/ +1 more | +15 | 0 replies | |
| 4/9 | selftests: ublk: track created devices for per-test cleanuptools/ | +12 | 0 replies | |
| 5/9 | selftests: ublk: add group-based test targetstools/ | +36 | 0 replies | |
| 6/9 | selftests: ublk: add _ublk_sleep helper for parallel executiontools/ tools/ tools/ | +12 | 0 replies | |
| 7/9 | selftests: ublk: increase timeouts for parallel test executiontools/ | +5 | 0 replies | |
| 8/9 | selftests: ublk: reorganize tests into integrity and recover groupstools/ tools/ tools/ +4 more | +8 | 0 replies | |
| 9/9 | selftests: ublk: improve I/O ordering test with bpftracetools/ tools/ tools/ +1 more | +54 | 0 replies |
Reviews trailers per patch
None of the 9 patches has a Reviewed-by or Acked-by.
| Patch | Alexander Atanasov |
|---|---|
| 1/9 | |
| 2/9 | |
| 3/9 | |
| 4/9 | |
| 5/9 | |
| 6/9 | |
| 7/9 | |
| 8/9 | |
| 9/9 | Reported-and-tested-by |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/9] selftests: ublk: test infrastructure improvements
Hi,
This series improves the ublk selftests infrastructure with better organization and parallel test execution support.
Key improvements:
1. Infrastructure enhancements:
- Add helper functions for device cleanup and parallel execution
- Implement group-based test targets for running test subsets
- Track created devices for proper per-test cleanup
- Increase timeouts to accommodate parallel test execution
- Test time can be reduced to 1/3 with parallel execution by passing JOBS=8
2. Test organization:
- Reorganize tests into logical groups (integrity, recover)
- Refactor large tests into modular functions for maintainability
3. I/O ordering verification:
- Remove test_generic_01.sh prone to false positives from block layer reordering
- Improve test_generic_02.sh with bpftrace-based verification
- Use block_io_start/block_rq_complete tracepoints for accurate tracking
These changes make the test suite more maintainable, easier to run in parallel, and more reliable in detecting actual ublk driver issues vs. false positives.
Ming Lei (9):
selftests: ublk: simplify UBLK_TEST_DIR handling
selftests: ublk: refactor test_loop_08 into separate functions
selftests: ublk: add _ublk_del_dev helper function
selftests: ublk: track created devices for per-test cleanup
selftests: ublk: add group-based test targets
selftests: ublk: add _ublk_sleep helper for parallel execution
selftests: ublk: increase timeouts for parallel test execution
selftests: ublk: reorganize tests into integrity and recover groups
selftests: ublk: improve I/O ordering test with bpftrace
tools/testing/selftests/ublk/Makefile | 54 ++++++-
tools/testing/selftests/ublk/test_common.sh | 51 +++++--
.../testing/selftests/ublk/test_generic_01.sh | 47 ------
.../testing/selftests/ublk/test_generic_02.sh | 22 ++-
.../testing/selftests/ublk/test_generic_16.sh | 4 +-
.../{test_null_04.sh => test_integrity_01.sh} | 8 +-
.../selftests/ublk/test_integrity_02.sh | 141 ++++++++++++++++++
tools/testing/selftests/ublk/test_loop_08.sh | 110 --------------
tools/testing/selftests/ublk/test_part_02.sh | 6 +-
...{test_generic_04.sh => test_recover_01.sh} | 0
...{test_generic_05.sh => test_recover_02.sh} | 0
...{test_generic_11.sh => test_recover_03.sh} | 0
...{test_generic_14.sh => test_recover_04.sh} | 0
tools/testing/selftests/ublk/trace/seq_io.bt | 47 ++++--
14 files changed, 284 insertions(+), 206 deletions(-)
delete mode 100755 tools/testing/selftests/ublk/test_generic_01.sh
rename tools/testing/selftests/ublk/{test_null_04.sh => test_integrity_01.sh} (96%)
create mode 100755 tools/testing/selftests/ublk/test_integrity_02.sh
delete mode 100755 tools/testing/selftests/ublk/test_loop_08.sh
rename tools/testing/selftests/ublk/{test_generic_04.sh => test_recover_01.sh} (100%)
rename tools/testing/selftests/ublk/{test_generic_05.sh => test_recover_02.sh} (100%)
rename tools/testing/selftests/ublk/{test_generic_11.sh => test_recover_03.sh} (100%)
rename tools/testing/selftests/ublk/{test_generic_14.sh => test_recover_04.sh} (100%)Signature · 1 line
2.47.0