Skip to content

sunrpc: Fix `make W=1` build issues

Andy Shevchenko linux-nfs lkml llvm netdev 3 versions Applied

Status from this message: Applied to nfsd-next just now. Should appear in linux-next the next

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 5 repliesApplied
  2. v23 patches 13 repliesSuperseded
  3. v11 patch 2 repliesSuperseded

Changes in v3 from the cover letter

- removed ifdeffery to have struct rpc_task::tk_pid available (LKP)
- collected more tags (Anna, Jeff)

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3nfs/blocklayout: Fix compilation error (`make W=1`) in bl_write_pagelist()fs/nfs/blocklayout/blocklayout.c+1 -30 replies
2/3sunrpc: Kill RPC_IFDEBUG()fs/nfsd/nfsfh.c include/linux/sunrpc/debug.h net/sunrpc/xprtrdma/svc_rdma_transport.c+20 -180 replies
3/3sunrpc: Fix compilation error (`make W=1`) when dprintk() is no-opfs/lockd/svclock.c include/linux/sunrpc/debug.h include/linux/sunrpc/sched.h+11 -50 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchAnna SchumakerJeff LaytonGeert Uytterhoeven
1/3A-b R-b
2/3R-b
3/3R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/3] sunrpc: Fix `make W=1` build issues

Compiler is not happy about unused variables (especially when dprintk() call is defined as no-op). Here is the series to address the issues.

Changelog v3:
- removed ifdeffery to have struct rpc_task::tk_pid available (LKP)
- collected more tags (Anna, Jeff)

v2: [email protected]

Changelog v2:
- added patch to kill RPC_IFDEBUG() macro (LKP, Geert)
- united separate patches in the series
- collected tags (Geert)

v1: [email protected]
v1: [email protected]

Andy Shevchenko (3):
nfs/blocklayout: Fix compilation error (make W=1) in
bl_write_pagelist()
sunrpc: Kill RPC_IFDEBUG()
sunrpc: Fix compilation error (make W=1) when dprintk() is no-op

 fs/lockd/svclock.c                       |  5 +++++
 fs/nfs/blocklayout/blocklayout.c         |  4 +---
 fs/nfsd/nfsfh.c                          |  9 +++++---
 include/linux/sunrpc/debug.h             | 10 +++++----
 include/linux/sunrpc/sched.h             |  3 ---
 net/sunrpc/xprtrdma/svc_rdma_transport.c | 27 ++++++++++++------------
 6 files changed, 32 insertions(+), 26 deletions(-)
Signature · 1 line
2.50.1