Skip to content

AST2700-A2 interrupt controller hierarchy and route support

Ryan Chen linux-arm-kernel linux-aspeed linux-devicetree linux-riscv lkml 5 versions – Applied

Status from this message: The following commit has been merged into the irq/drivers branch of tip:

Get series with b4
b4 am [email protected] change-id 20260205-irqchip-7eaef3674de9

Versions newest first

  1. v5 Latest4 patches 1 replyApplied
  2. v44 patches 2 repliesSuperseded
  3. v34 patches 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v25 patches3 repliesSuperseded
v14 patches13 repliesSuperseded

Changes in v5 from the cover letter

- 2/4 reduce unnecessary line breaks.
- 2/4, 3/4 fix enable CONFIG_PROVE_LOCKING irq lock inversion dependency detected.
- Link to v4: https://lore.kernel.org/r/[email protected]

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/4dt-bindings: interrupt-controller: Describe AST2700-A2 hardware instead of A0Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2700-intc.yaml Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2700-interrupt.yaml+188 -901 reply
2/4irqchip/ast2700-intc: Add AST2700-A2 supportdrivers/irqchip/Kconfig drivers/irqchip/Makefile drivers/irqchip/irq-ast2700-intc0.c +3 more+1029 -00 replies
3/4irqchip/ast2700-intc: Add KUnit tests for route resolutiondrivers/irqchip/.kunitconfig drivers/irqchip/Kconfig drivers/irqchip/Makefile +2 more+492 -10 replies
4/4irqchip/aspeed-intc: Remove AST2700-A0 supportdrivers/irqchip/Makefile drivers/irqchip/irq-aspeed-intc.c+0 -1400 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchRob Herring (Arm)
1/4R-b
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/4] AST2700-A2 interrupt controller hierarchy and route support

The AST2700 SoC has undergone multiple silicon revisions (A0, A1, A2) prior to mass production.

A0 laid the ground-work with a split controller design (INTC0 and INTC1) used for early development and bring-up. The interrupt architecture was substantially reworked in the A1 to introduce an explicit routing model and clearer hierarchy, though the split controllers remained. The A1 interrupt architecture is unchanged in A2.

A2 is the production design. A0 and A1 are pre-production silicon and are no longer intended for deployment outside of ASPEED.

The existing binding and driver were written against A0 prior to the A1 rework. The A0 design directly wired INTC1 instances to INTC0, and INTC0 to the GIC of the Primary Service Processor (PSP, a Cortex-A35). The A0 binding and driver therefore do not account for the alternative destinations of the Secondary and Tertiary Service Processors (SSP, TSP) and BootMCU, or the necessary route selection logic present in the production design.

With the above context, this series replaces the existing binding and driver.

It is not necessary for projects to maintain support for A0 due to its pre-production nature, and between Linux, U-Boot and Zephyr there are no upstream devicetree users of the current binding.

The new binding uses localised interrupt numbers and models the hardware connectivity between interrupt controllers using the aspeed,interrupt-ranges property. It is introduced in a new file before the existing binding is removed in order to keep the diff readable.

The INTC0 driver creates a hierarchical irqdomain under the selected upstream interrupt controller and implements route resolution logic. INTC1 driver instances defer route selection to INTC0 and expose a linear interrupt namespace to their parent.

A brief history of related submissions
--------------------------------------

Some modifications to the existing binding were sent to the lists in the past. Due to process choices the revisions were difficult to track. They are listed below.

The approaches took several forms but ended in the minor adjustment in v6 being applied. This enabled use of the A1 design but requires assumptions about platform route configuration defined in firmware. These assumptions are removed by this current series.

* [PATCH] dt-bindings: interrupt-controller: aspeed: Refine AST2700 binding description and example
https://lore.kernel.org/all/[email protected]/

* [PATCH v2] dt-bindings: interrupt-controller: aspeed: Add parent node compatibles and refine documentation
https://lore.kernel.org/all/[email protected]/

* [PATCH v3 0/2] irqchip: aspeed: Add AST2700 INTC debugfs support and yaml update
https://lore.kernel.org/all/[email protected]/

* [PATCH v4 0/2] irqchip/ast2700-intc: Add AST2700 INTC debugfs support and yaml update
https://lore.kernel.org/all/[email protected]/

* [PATCH v5 0/3] AST2700 interrupt controller hierarchy support
https://lore.kernel.org/all/[email protected]/

* [PATCH v6 0/1] Update correct AST2700 interrupt controller binding
https://lore.kernel.org/all/[email protected]/

---
Changes in v5:
- 2/4 reduce unnecessary line breaks.
- 2/4, 3/4 fix enable CONFIG_PROVE_LOCKING irq lock inversion dependency detected.
- Link to v4: https://lore.kernel.org/r/[email protected]

Changes in v4:
- 3/4 fix warning: the frame size of 1296 bytes is larger than 1280 bytes
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- 1/4 Squash patch 5/5 and 1/5.
- 1/4 modify wrap lines at 80 char.
- 1/4 modify maintainers name and email.
- 1/4 modify typo Sevice-> Service
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Change suject to "AST2700-A2 interrupt controller hierarchy and route support".
- Describe timeline for (pre-)production design evolution and
binding development to support the break in compatibility.
- fix "make dt_binding_check" compatible string consistance with
example.
- Split KUnit coverage out of the main driver patch.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Ryan Chen (4):
dt-bindings: interrupt-controller: Describe AST2700-A2 hardware instead of A0 irqchip/ast2700-intc: Add AST2700-A2 support irqchip/ast2700-intc: Add KUnit tests for route resolution irqchip/aspeed-intc: Remove AST2700-A0 support

 .../interrupt-controller/aspeed,ast2700-intc.yaml  |  90 ----
 .../aspeed,ast2700-interrupt.yaml                  | 188 +++++++
 drivers/irqchip/.kunitconfig                       |   5 +
 drivers/irqchip/Kconfig                            |  23 +
 drivers/irqchip/Makefile                           |   3 +-
 drivers/irqchip/irq-aspeed-intc.c                  | 139 -----
 drivers/irqchip/irq-ast2700-intc0-test.c           | 473 +++++++++++++++++
 drivers/irqchip/irq-ast2700-intc0.c                | 582 +++++++++++++++++++++
 drivers/irqchip/irq-ast2700-intc1.c                | 280 ++++++++++
 drivers/irqchip/irq-ast2700.c                      | 107 ++++
 drivers/irqchip/irq-ast2700.h                      |  48 ++
 11 files changed, 1708 insertions(+), 230 deletions(-)

---
base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
change-id: 20260205-irqchip-7eaef3674de9

Best regards,

Signature · 1 line
Ryan Chen <[email protected]>