Skip to content

mptcp: fix stall because of data_ready

Gang Yan mptcp 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest5 patches 12 repliesIn review
  2. v45 patches 1 replySuperseded
  3. v33 patches 2 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v2 posting 2/21 patch1 replySuperseded
v2 posting 1/21 patch0 repliesSuperseded

Changes in v5 from the cover letter

- Patch 1 fixes missing initialization of msk->backlog_unaccounted in __mptcp_init_sock() to match the commit message.
- Patch 4 removes the 'else' branch to fix potential TOCTOU race and fix typo in title.
- Patch 5 drops the redundant tcp_rmem restore.
- Add notes in some patches of the series in response to the AI review.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5mptcp: replace backlog_list with backlog_queuenet/mptcp/protocol.c net/mptcp/protocol.h+63 -127 replies
2/5mptcp: fix the stall problems using backlog_queuenet/mptcp/protocol.c+8 -20 replies
3/5mptcp: fix the stall problems with data_readynet/mptcp/protocol.c+21 -10 replies
4/5mptcp: fix the dead_lock in mptcp_data_readynet/mptcp/protocol.c+3 -23 replies
5/5selftests: mptcp: test transmission with small rcvbuftools/testing/selftests/net/mptcp/mptcp_join.sh+17 -02 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH mptcp-net v5 0/5] mptcp: fix stall because of data_ready

From: Gang Yan <[email protected]>

Changelog:
V5:
- Patch 1 fixes missing initialization of msk->backlog_unaccounted in __mptcp_init_sock() to match the commit message.
- Patch 4 removes the 'else' branch to fix potential TOCTOU race and fix typo in title.
- Patch 5 drops the redundant tcp_rmem restore.
- Add notes in some patches of the series in response to the AI review.
v4:
- Pass 'delta' to 'move_skbs_to_msk' to fix the potential problems, and add a helper named 'move_skbs_from_backlog' to achieve this.
- Add a test case in mptcp_join.sh which can reproduce such stall prolems.
- Fix a dead_lock problems which is imported in the 1d77124a6322 ('mptcp: fix the stall problems with data_ready.').
v3:
- Replace backlog list with backlog_queue(rb-tree) to solve the stall problems.

v2:

v1:

Gang Yan (5):
mptcp: replace backlog_list with backlog_queue
mptcp: fix the stall problems using backlog_queue
mptcp: fix the stall problems with data_ready
mptcp: fix the dead_lock in mptcp_data_ready
selftests: mptcp: test transmission with small rcvbuf

 net/mptcp/protocol.c                          | 110 +++++++++++++++---
 net/mptcp/protocol.h                          |   2 +-
 .../testing/selftests/net/mptcp/mptcp_join.sh |  17 +++
 3 files changed, 112 insertions(+), 17 deletions(-)
Signature · 1 line
2.43.0