Skip to content

regcache: Avoid accessing non-initialised cache

Andy Shevchenko driver-core lkml 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 1 replyIn review
  2. v52 patches 3 repliesSuperseded
  3. v43 patches 3 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v33 patches5 repliesSuperseded
v25 patches9 repliesSuperseded
v13 patches2 repliesSuperseded

Changes in v6 from the cover letter

- refactored to make sure we always clean up the allocated resources (Mark)
- dropped applied patches

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3regcache: Move count check and cache_bypass assignment to the callerdrivers/base/regmap/regcache.c+4 -40 replies
2/3regcache: Allocate and free reg_defaults on the same leveldrivers/base/regmap/regcache.c+15 -190 replies
3/3regcache: Move HW readback after cache initialisationdrivers/base/regmap/regcache.c+15 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [PATCH v6 0/3] regcache: Avoid accessing non-initialised cache

Refactor regcache flow that populates cache on initialisation phase based on the values in HW. This makes code robust against any possible accesses to not-fully initialised caches.

Changelog v6:
- refactored to make sure we always clean up the allocated resources (Mark)
- dropped applied patches

v5: [email protected]

Changelog v5:
- added a precursor patch to make things clearer
- also put the freeing resources into an order (Mark)
- dropped applied patches

v4: [email protected]

Changelog v4:
- made conditional against 'count' to make it less dependent to the previous code path

v3: [email protected]

Changelog v3:
- dropped unneeded churn in patch 3 (Mark)
- fixed code to pass kunit test cases (Mark)

v2: [email protected]

Changelog v2:
- rebased on top of the latest regmap changes (Mark)
- added two more little cleanups (patches 4 & 5)

Andy Shevchenko (3):
regcache: Move count check and cache_bypass assignment to the caller
regcache: Allocate and free reg_defaults on the same level
regcache: Move HW readback after cache initialisation

 drivers/base/regmap/regcache.c | 63 +++++++++++++++++-----------------
 1 file changed, 31 insertions(+), 32 deletions(-)
Signature · 1 line
2.50.1