Skip to content

rtc: max77686: convert to i2c_new_ancillary_device

Svyatoslav Ryhel linux-devicetree linux-gpio lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 5 repliesIn review
  2. v45 patches 11 repliesApplied
  3. v36 patches 10 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v22 patches1 replySuperseded
v12 patches3 repliesSuperseded

Changes in v5 from the cover letter

- fixed pincontrol schema
- dropped applied patches

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2regulator: dt-bindings: regulator-max77620: convert to DT schemaDocumentation/devicetree/bindings/regulator/maxim,max77620-regulator.yaml Documentation/devicetree/bindings/regulator/regulator-max77620.txt+99 -2220 replies
2/2dt-bindings: pinctrl: pinctrl-max77620: convert to DT schemaDocumentation/devicetree/bindings/pinctrl/maxim,max77620-pinctrl.yaml Documentation/devicetree/bindings/pinctrl/pinctrl-max77620.txt+98 -1274 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchMark BrownRob Herring (Arm)
1/2A-b R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/2] rtc: max77686: convert to i2c_new_ancillary_device

Convert RTC I2C device creation from devm_i2c_new_dummy_device() to i2c_new_ancillary_device() to enable the use of a device tree-specified RTC address instead of a hardcoded value. If the device tree does not provide an address, use hardcoded values as a fallback.

This addresses an issue with the MAX77663 PMIC, which can have the RTC at different I2C positions (either 0x48, like the MAX77714, or 0x68, like the MAX77620). The MAX77620 value is used as the default. The I2C position of the MAX77663 is factory-set and cannot be detected from the chip itself.

I have tested this patch on LG Optimus Vu P895 with max77663 PMIC and non-default RTC position. RTC is registered correctly.

---
Changes in v5
- fixed pincontrol schema
- dropped applied patches

Changes in v4
- adjusted pinconfig node naming
- changed interrupt in the example
- fixed indentation in the example
- corrected pinconfig node name in the example
- commit "dt-bindings: gpio: trivial-gpio: remove max77620 compatible" squashed with the converting patch for this compatible

Changes in v3
- max77620 files converted to DT schema.

Changes in v2
- dropped patch that changes max77686 and adjusted max77620 where max77663 is described.
---

Svyatoslav Ryhel (2):
regulator: dt-bindings: regulator-max77620: convert to DT schema
dt-bindings: pinctrl: pinctrl-max77620: convert to DT schema

 .../pinctrl/maxim,max77620-pinctrl.yaml       |  98 ++++++++
 .../bindings/pinctrl/pinctrl-max77620.txt     | 127 ----------
 .../regulator/maxim,max77620-regulator.yaml   |  99 ++++++++
 .../bindings/regulator/regulator-max77620.txt | 222 ------------------
 4 files changed, 197 insertions(+), 349 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/maxim,max77620-pinctrl.yaml
 delete mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-max77620.txt
 create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max77620-regulator.yaml
 delete mode 100644 Documentation/devicetree/bindings/regulator/regulator-max77620.txt
Signature · 1 line
2.51.0