iio: dac: ad5504: bindings, cleanups, locking, and scale fixes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest6 patches 6 repliesIn review
- v56 patches 6 repliesSuperseded
- v46 patches 13 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 5 patches | 7 replies | Superseded | |
| v2 | 5 patches | 13 replies | Superseded | |
| v1 | 2 patches | 8 replies | Superseded |
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | dt-bindings: iio: dac: ad5504: add output-range and missing gpiosDocumentation/ | +38 | 4 replies | |
| 2/6 | iio: dac: ad5504: Align headers with IWYU principledrivers/ | +8 | 0 replies | |
| 3/6 | iio: dac: ad5504: separate ACPI and DT pathsdrivers/ | +20 | 0 replies | |
| 4/6 | iio: dac: ad5504: remove legacy platform data supportdrivers/ include/ | +5 | 0 replies | |
| 5/6 | iio: dac: ad5504: introduce local lock to protect state and spi transfersdrivers/ | +24 | 0 replies | |
| 6/6 | iio: dac: ad5504: support scale via output-range-microvolt propertydrivers/ | +25 | 2 replies |
Reviews trailers per patch
1 of 6 patches has a Reviewed-by or Acked-by.
| Patch | Conor Dooley |
|---|---|
| 1/6 | A-b |
| 2/6 | |
| 3/6 | |
| 4/6 | |
| 5/6 | |
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v6 0/6] iio: dac: ad5504: bindings, cleanups, locking, and scale fixes
Jonathan Cameron applied patches 2 (sort headers alphabetically) and 4 (introduce local dev pointer) from v3 directly to iio/testing. This series rebases on top of that state and does not re-send those patches.
This v6 series addresses one remaining item from the v5 review by Andy Shevchenko:
* In ad5504_write_dac_powerdown(), move guard(mutex) to after kstrtobool() since input parsing does not touch shared state and does not need to be under the lock (Andy)
Testing:
No functional change from v5. This only narrows the critical section in one sysfs write path. Re-verified on ARM64 Raspberry Pi 5 (BCM2712):
powerdown sysfs read/write and powerdown mode switching (20kohm_to_gnd, three_state) verified on all four channels without errors.
Previous versions:
v5: https://lore.kernel.org/linux-iio/[email protected]/
v4: https://lore.kernel.org/linux-iio/[email protected]/
v3: https://lore.kernel.org/linux-iio/[email protected]/
v2: https://lore.kernel.org/linux-iio/[email protected]/
v1: https://lore.kernel.org/linux-iio/[email protected]/
Thank you to Jonathan Cameron, David Lechner, Andy Shevchenko, Nuno Sá, Krzysztof Kozlowski, Conor Dooley, Uwe Kleine-König, and Joshua Crofts for the continued reviews.
Taha Ed-Dafili (6):
dt-bindings: iio: dac: ad5504: add output-range and missing gpios
iio: dac: ad5504: Align headers with IWYU principle
iio: dac: ad5504: separate ACPI and DT paths
iio: dac: ad5504: remove legacy platform data support
iio: dac: ad5504: introduce local lock to protect state and spi
transfers
iio: dac: ad5504: support scale via output-range-microvolt property
.../bindings/iio/dac/adi,ad5504.yaml | 39 ++++++++- drivers/iio/dac/ad5504.c | 82 +++++++++++++++---- include/linux/iio/dac/ad5504.h | 15 ---- 3 files changed, 103 insertions(+), 33 deletions(-) delete mode 100644 include/linux/iio/dac/ad5504.h
Signature · 1 line
2.55.0