Skip to content

10-bit packed raw support, other fixes and improvements

Sakari Ailus linux-media 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest9 of 11 patches 12 repliesIn review
  2. v33 patches 5 repliesSuperseded
  3. v23 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches2 repliesSuperseded

Changes in v4 from the cover letter

- Add more patches for cleanups and fixes in general.

- Allow setting stride, with format thhe height is calculated. This is practical for use with e.g. yavta, which can write multiple images into the same file.

- Simplified calculation of offsets in 10-bit packed Bayer unpacking.

- Compare old format info pointer to determine a supported format has been found.

9 of 11 patches are in this archive. The cover letter announces 11.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11Add explicit switch fallthrough notationraw2rgbpnm.c+4 -40 replies
2/11Add compiler options to avoid warningsMakefile+1 -11 reply
3/11Add 10-bit CSI-2 packed format supportraw2rgbpnm.c+82 -02 replies
4/11Support long options and improve help textraw2rgbpnm.c+25 -94 replies
5/11Add "help" for listing formats and de-Bayering algos, document itraw2rgbpnm.c+4 -41 reply
6/11The program has been called raw2rgbpnm, not yuv_to_rgbpnm awhile nowraw2rgbpnm.c+1 -11 reply
7/11Arrange headers alphabeticallyraw2rgbpnm.c+1 -11 reply
8/11Add --stride (-S) option for setting strideraw2rgbpnm.c+15 -91 reply
9/11Improve input validationraw2rgbpnm.c+14 -51 reply

Reviews trailers per patch

7 of 9 patches have a Reviewed-by or Acked-by.

PatchLaurent Pinchart
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b
7/11
8/11R-b
9/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [raw2rgbpnm PATCH v4 00/11] 10-bit packed raw support, other fixes and improvements

Hi all,

These patches add support for 10-bit packed raw formats. Adding support for more bit depths would be trivial (at least up to 16 bits) but I only needed 10. :-)

The code could be prettier.

since v3:

- Add more patches for cleanups and fixes in general.

- Allow setting stride, with format thhe height is calculated. This is practical for use with e.g. yavta, which can write multiple images into the same file.

- Simplified calculation of offsets in 10-bit packed Bayer unpacking.

- Compare old format info pointer to determine a supported format has been found.

since v2:

- Drop bpc argument from raw_get() and raw_put(). The bpc argument wasn't really needed there as the functions don't operate on the values (but simply pack or unpack them).

- Use unsigned values where appropriate (i.e. make signed values unsigned).

since v1:

- Use __attribute__((fallthrough)) instead of a compiler flag.

- Better error message on what's wrong if a proper unpacked format isn't found when processing the newly supported packed 10-bit raw formats.

Sakari Ailus (11):
Add explicit switch fallthrough notation
Add compiler options to avoid warnings
Add 10-bit CSI-2 packed format support
Support long options and improve help text
Add "help" for listing formats and de-Bayering algos, document it The program has been called raw2rgbpnm, not yuv_to_rgbpnm awhile now Arrange headers alphabetically
Add --stride (-S) option for setting stride
Improve input validation
Ensure width is divisible by 4 for packed 10-bit formats Add -S option for setting stride

 Makefile     |   2 +-
 raw2rgbpnm.c | 199 ++++++++++++++++++++++++++++++++++++++++-----------
 2 files changed, 160 insertions(+), 41 deletions(-)
Signature · 1 line
2.47.3