Skip to content

mm/hugetlb: fixes for PMD table sharing (incl. using mmu_gather)

David Hildenbrand (Arm) linux-mm stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7mm/hugetlb: fix skipping of unsharing of pmd page tablesmm/hugetlb.c+4 -10 replies
2/7mm/hugetlb: make detecting shared pte more reliablemm/hugetlb.c+7 -120 replies
3/7mm/hugetlb: fix copy_hugetlb_page_range() to use ->pt_share_countmm/hugetlb.c+4 -90 replies
4/7mm/hugetlb: fix hugetlb_pmd_shared()include/linux/hugetlb.h+1 -10 replies
5/7mm/hugetlb: fix two comments related to huge_pmd_unshare()mm/hugetlb.c+8 -160 replies
6/7mm/rmap: fix two comments related to huge_pmd_unshare()mm/rmap.c+2 -70 replies
7/7mm/hugetlb: fix excessive IPI broadcasts when unsharing PMD tables using mmu_gatherinclude/asm-generic/tlb.h include/linux/hugetlb.h include/linux/mm_types.h +3 more+195 -540 replies

Reviews trailers per patch

6 of 7 patches have a Reviewed-by or Acked-by.

PatchMike KravetzHarry YooOscar SalvadorDavid HildenbrandRik van RielLance YangLaurence ObermanLorenzo Stoakes
1/7
2/7R-b
3/7R-b A-b A-b
4/7R-b A-b R-b R-b T-b T-b R-b
5/7R-b A-b R-b T-b R-b
6/7A-b R-b T-b R-b
7/7A-b T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.

Read the v1 thread

Cover letter [PATCH 5.10.y 0/7] mm/hugetlb: fixes for PMD table sharing (incl. using mmu_gather)

Backport of [1] for 5.10. Backport notes are in the individual patches.

I found one bug in a previous backport, fix in patch #1.

I'm also including a cleanup/fix from Miaohe that makes backporting at least a bit easier, followed by the fix from Jane.

Tested on x86-64 with the original reproducer.

[1] https://lore.kernel.org/linux-mm/[email protected]/

Cc Jane Chu <[email protected]>
Cc Harry Yoo <[email protected]>
Cc Oscar Salvador <[email protected]>
Cc Jann Horn <[email protected]>
Cc Liu Shixin <[email protected]>
Cc Muchun Song <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Rik van Riel <[email protected]>
Cc Laurence Oberman <[email protected]>
Cc Lance Yang <[email protected]>
Cc Liu Shixin <[email protected]>
Cc Miaohe Lin <[email protected]>
Cc James Houghton <[email protected]>

David Hildenbrand (Arm) (1):
mm/hugetlb: fix skipping of unsharing of pmd page tables

David Hildenbrand (Red Hat) (4):
mm/hugetlb: fix hugetlb_pmd_shared()
mm/hugetlb: fix two comments related to huge_pmd_unshare() mm/rmap: fix two comments related to huge_pmd_unshare() mm/hugetlb: fix excessive IPI broadcasts when unsharing PMD tables
using mmu_gather

Jane Chu (1):
mm/hugetlb: fix copy_hugetlb_page_range() to use ->pt_share_count

Miaohe Lin (1):
mm/hugetlb: make detecting shared pte more reliable

 include/asm-generic/tlb.h |  77 +++++++++++++++++++-
 include/linux/hugetlb.h   |  17 +++--
 include/linux/mm_types.h  |   2 +
 mm/hugetlb.c              | 143 ++++++++++++++++++++------------------
 mm/mmu_gather.c           |  36 ++++++++++
 mm/rmap.c                 |  20 +++---
 6 files changed, 208 insertions(+), 87 deletions(-)
Signature · 1 line
2.43.0