Skip to content

net/axgbe: fix resource leaks and OOB access

Stephen Hemminger dpdk-dev 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 0 repliesNew
  2. v24 patches 0 repliesSuperseded
  3. v14 patches 7 repliesSuperseded

Changes in v3 from the cover letter

- Patch 1: consolidate the error-path cleanup
- Patch 2: split Rx buffer setup into two passes

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4net/axgbe: fix resource leaks in device init error pathsdrivers/net/axgbe/axgbe_ethdev.c+25 -100 replies
2/4net/axgbe: fix Rx queue leak on descriptor init failuredrivers/net/axgbe/axgbe_dev.c+24 -190 replies
3/4net/axgbe: destroy mutexes on device closedrivers/net/axgbe/axgbe_ethdev.c+5 -00 replies
4/4net/axgbe: fix descriptor status out-of-bounds accessdrivers/net/axgbe/axgbe_rxtx.c+4 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/4] net/axgbe: fix resource leaks and OOB access

A code review of the axgbe PMD turned up several correctness bugs, most of them in resource management on the device initialization error paths, plus an out-of-bounds descriptor ring access.

v3:
- Patch 1: consolidate the error-path cleanup
- Patch 2: split Rx buffer setup into two passes

Stephen Hemminger (4):
net/axgbe: fix resource leaks in device init error paths net/axgbe: fix Rx queue leak on descriptor init failure net/axgbe: destroy mutexes on device close net/axgbe: fix descriptor status out-of-bounds access

 drivers/net/axgbe/axgbe_dev.c    | 43 ++++++++++++++++++--------------
 drivers/net/axgbe/axgbe_ethdev.c | 40 +++++++++++++++++++++--------
 drivers/net/axgbe/axgbe_rxtx.c   |  8 +++---
 3 files changed, 58 insertions(+), 33 deletions(-)
Signature · 1 line
2.53.0