Skip to content

nvme: set discard_granularity from NPDG/NPDA

Caleb Sander Mateos linux-nvme lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest8 patches 4 repliesIn review
  2. v48 patches 3 repliesSuperseded
  3. v38 patches 2 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v27 patches6 repliesSuperseded
v16 patches11 repliesSuperseded

Changes in v5 from the cover letter

- Only issue NVM Command Set Specific Identify Namespace if controller version supports CNS value (Keith)
- Check for multiplication overflow (Keith)

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8nvme: add preferred I/O size fields to struct nvme_id_ns_nvminclude/linux/nvme.h+8 -10 replies
2/8nvme: fold nvme_config_discard() into nvme_update_disk_info()drivers/nvme/host/core.c+19 -240 replies
3/8nvme: update nvme_id_ns OPTPERF constantsdrivers/nvme/host/core.c include/linux/nvme.h+12 -20 replies
4/8nvme: always issue I/O Command Set specific Identify Namespacedrivers/nvme/host/core.c+1 -10 replies
5/8nvme: add from0based() helperdrivers/nvme/host/nvme.h+6 -00 replies
6/8nvme: set discard_granularity from NPDG/NPDAdrivers/nvme/host/core.c+32 -30 replies
7/8nvmet: use NVME_NS_FEAT_OPTPERF_SHIFTdrivers/nvme/target/io-cmd-bdev.c+2 -20 replies
8/8nvmet: report NPDGL and NPDALdrivers/nvme/target/admin-cmd.c drivers/nvme/target/io-cmd-bdev.c drivers/nvme/target/nvmet.h+19 -40 replies

Reviews trailers per patch

5 of 8 patches have a Reviewed-by or Acked-by.

PatchChristoph Hellwig
1/8R-b
2/8R-b
3/8
4/8R-b
5/8
6/8
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/8] nvme: set discard_granularity from NPDG/NPDA

NVMe block devices always report the logical block size for the discard_granularity queue limit. However, more accurate values may be available in the NPDG/NPDA fields of the Identify Namespace structure or the NPDGL/NPDAL fields of the NVM Command Set Specific Identify Namespace structure. So use these values to compute discard_granularity.

Also fix the use of the OPTPERF field to better comply with version 2.1 of the NVMe spec.

Update the target side to report NPDGL and NPDAL as well, in case the discard granularity doesn't fit in the 16-bit NPDG and NPDA fields.

v5:
- Only issue NVM Command Set Specific Identify Namespace if controller version supports CNS value (Keith)
- Check for multiplication overflow (Keith)

v4:
- Issue NVM Command Set Specific Identify Namespace regardless of controller version (Keith)

v3:
- Introduce from0based() (Christoph)
- Fix merge conflict resolution (Keith)
- Add more comments (Christoph)
- Add Reviewed-by tags (Christoph)

v2:
- Only use low bit of OPTPERF on pre-2.1 controllers (Christoph)
- Add Reviewed-by tags (Christoph)

Caleb Sander Mateos (8):
nvme: add preferred I/O size fields to struct nvme_id_ns_nvm
nvme: fold nvme_config_discard() into nvme_update_disk_info()
nvme: update nvme_id_ns OPTPERF constants
nvme: always issue I/O Command Set specific Identify Namespace
nvme: add from0based() helper
nvme: set discard_granularity from NPDG/NPDA
nvmet: use NVME_NS_FEAT_OPTPERF_SHIFT
nvmet: report NPDGL and NPDAL

 drivers/nvme/host/core.c          | 86 +++++++++++++++++++++----------
 drivers/nvme/host/nvme.h          |  6 +++
 drivers/nvme/target/admin-cmd.c   |  2 +
 drivers/nvme/target/io-cmd-bdev.c | 19 +++++--
 drivers/nvme/target/nvmet.h       |  2 +
 include/linux/nvme.h              | 15 +++++-
 6 files changed, 96 insertions(+), 34 deletions(-)
Signature · 1 line
2.45.2