RFC Adding NO_STA flag and reworking RX link resolution
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 RFC Latest8 patches 13 repliesIn review
- v1 RFC8 patches 3 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | wifi: iwlwifi: use link_sta internally to the driverdrivers/ drivers/ drivers/ +2 more | +42 | 0 replies | |
| 2/8 | wifi: mac80211: change public RX API to use link stationsdrivers/ drivers/ drivers/ +8 more | +65 | 3 replies | |
| 3/8 | wifi: mac80211: refactor RX link_id and station handlinginclude/ net/ net/ +3 more | +105 | 0 replies | |
| 4/8 | wifi: mac80211: rework RX packet handlingnet/ | +169 | 0 replies | |
| 5/8 | wifi: cfg80211: add attribute for TX/RX denoting there is no stationinclude/ include/ net/ | +18 | 0 replies | |
| 6/8 | wifi: mac80211: report to cfg80211 when no STA is known for a framenet/ | +1 | 0 replies | |
| 7/8 | wifi: mac80211: pass station to ieee80211_tx_skb_tidnet/ net/ net/ +4 more | +22 | 2 replies | |
| 8/8 | wifi: mac80211: pass error station if non-STA transmit was requestednet/ | +9 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [RFC PATCH v2 0/8] Adding NO_STA flag and reworking RX link resolution
From: Benjamin Berg <[email protected]>
Hi,
This patchset refactors the RX link resolution a bit to fix some issues where mac80211 might accept frames on the wrong link and incorrectly translate the address. It also adds a new NL80211_ATTR_FRAME_CMD_NO_STA flag so that userspace can know whether address translation was done by the kernel on RX and can also prevent address translation for management frames during TX.
This together should be enough to fix the existing issues in hostapd where stations that are still associated try to authenticate again but hostapd for example ends up sending the frame to an old link address.
I would appreciate if you test the patches and work on the hostapd side. Note that I have not properly verified the new nl80211 API, so it could well be that I missed something.
Benjamin
Changes in RFCv2:
* Port other drivers to new API (untested)
* Fix a checkpatch warning
Benjamin Berg (8):
wifi: iwlwifi: use link_sta internally to the driver
wifi: mac80211: change public RX API to use link stations
wifi: mac80211: refactor RX link_id and station handling
wifi: mac80211: rework RX packet handling
wifi: cfg80211: add attribute for TX/RX denoting there is no station
wifi: mac80211: report to cfg80211 when no STA is known for a frame
wifi: mac80211: pass station to ieee80211_tx_skb_tid
wifi: mac80211: pass error station if non-STA transmit was requested
drivers/net/wireless/ath/ath11k/dp_rx.c | 2 +- drivers/net/wireless/ath/ath12k/dp_mon.c | 18 +- drivers/net/wireless/ath/ath12k/dp_rx.c | 15 +- drivers/net/wireless/intel/iwlwifi/mld/agg.c | 21 +- drivers/net/wireless/intel/iwlwifi/mld/agg.h | 4 +- drivers/net/wireless/intel/iwlwifi/mld/rx.c | 50 +- drivers/net/wireless/intel/iwlwifi/mld/rx.h | 2 +- .../wireless/intel/iwlwifi/mld/tests/agg.c | 7 +- drivers/net/wireless/intel/iwlwifi/mvm/rx.c | 2 +- drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c | 6 +- drivers/net/wireless/mediatek/mt76/mac80211.c | 22 +- drivers/net/wireless/realtek/rtw89/core.c | 6 - drivers/net/wireless/virtual/mac80211_hwsim.c | 3 - include/net/cfg80211.h | 4 + include/net/mac80211.h | 25 +- include/uapi/linux/nl80211.h | 7 + net/mac80211/agg-tx.c | 6 +- net/mac80211/eht.c | 3 - net/mac80211/ht.c | 4 +- net/mac80211/ieee80211_i.h | 14 +- net/mac80211/iface.c | 7 +- net/mac80211/mlme.c | 9 +- net/mac80211/offchannel.c | 13 +- net/mac80211/rx.c | 436 ++++++++++-------- net/mac80211/scan.c | 10 +- net/mac80211/tdls.c | 4 +- net/mac80211/tx.c | 8 +- net/wireless/nl80211.c | 8 +- 28 files changed, 390 insertions(+), 326 deletions(-)
Signature · 1 line
2.53.0