Improve zoned (SMR) HDD write throughput
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest8 patches 6 repliesApplied
- v38 patches 14 repliesSuperseded
- v27 patches 10 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 8 patches | 22 replies | Superseded |
Changes in v4 from the cover letter
- Corrected patch 6 to remove the unnecessary blk_queue_is_zoned() check in queue_zoned_qd1_writes_store(), as well as the commit message to mention the visibility of the zoned_qd1_writes sysfs attribute.
- Corrected the documentation text in patch 8 to better describe the visibility of the zoned_qd1_writes sysfs attribute.
- Added review tags.
Patches in v4 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | block: fix zone write plug removalblock/ | +57 | 3 replies | |
| 2/8 | block: fix zone write plugs refcount handling in disk_zone_wplug_schedule_bio_work()block/ | +8 | 0 replies | |
| 3/8 | block: rename and simplify disk_get_and_lock_zone_wplug()block/ | +10 | 1 reply | |
| 4/8 | block: remove disk_zone_is_full()block/ | +3 | 0 replies | |
| 5/8 | block: rename struct gendisk zone_wplugs_lock fieldblock/ include/ | +13 | 0 replies | |
| 6/8 | block: allow submitting all zone writes from a single contextblock/ block/ block/ +1 more | +212 | 1 reply | |
| 7/8 | block: default to QD=1 writes for blk-mq rotational zoned devicesblock/ | +8 | 0 replies | |
| 8/8 | Documentation: ABI: stable: document the zoned_qd1_writes attributeDocumentation/ | +15 | 0 replies |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | Christoph Hellwig | Bart Van Assche | Johannes Thumshirn | Hannes Reinecke |
|---|---|---|---|---|
| 1/8 | R-b | R-b | ||
| 2/8 | R-b | R-b | R-b | |
| 3/8 | R-b | R-b | ||
| 4/8 | R-b | R-b | R-b | R-b |
| 5/8 | R-b | R-b | R-b | R-b |
| 6/8 | R-b | R-b | R-b | |
| 7/8 | R-b | R-b | R-b | R-b |
| 8/8 | R-b | R-b | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v4 0/8] Improve zoned (SMR) HDD write throughput
Jens,
This patch series cleans up the zone write plugging code and introduces the ability to issue all write BIOs from a single context (a kthread) instead of allowing multiple zones to be written at the same time using a per zone work. As shown in patch 6, raw block device tests and XFS tests with an SMR HDD show that this can significantly increase write throughput (up to 40% over the current zone write plugging).
Changes from v3:
- Corrected patch 6 to remove the unnecessary blk_queue_is_zoned() check in queue_zoned_qd1_writes_store(), as well as the commit message to mention the visibility of the zoned_qd1_writes sysfs attribute.
- Corrected the documentation text in patch 8 to better describe the visibility of the zoned_qd1_writes sysfs attribute.
- Added review tags.
Changes from v2:
- Modified patch 1 slightly to not restore dead zones and instead check for such state in the BIO submission path and fail BIOs that are submitted to dead zones as that represents an erroneous use of zones.
- Added patch 3
- Added review tags.
Changes from v1:
- Reworked patch 1 to remove the fragile use of refcount_read. Zone write plug removal is now more solid by being controlled with refcount_dec_and_test().
- Changed patch 2 to keep the refcount increase before scheduling the BIO work but drop that reference if scheduling the work did nothing.
- Dropped the patch "block: remove BLK_ZONE_WPLUG_UNHASHED" as the patch 1 changes make it unnecessary.
- Modified patch 5 to have the zoned_qd1_writes attribute visible only for zoned block devices.
- Added review tags
Damien Le Moal (8):
block: fix zone write plug removal
block: fix zone write plugs refcount handling in
disk_zone_wplug_schedule_bio_work()
block: rename and simplify disk_get_and_lock_zone_wplug()
block: remove disk_zone_is_full()
block: rename struct gendisk zone_wplugs_lock field
block: allow submitting all zone writes from a single context
block: default to QD=1 writes for blk-mq rotational zoned devices
Documentation: ABI: stable: document the zoned_qd1_writes attribute
Documentation/ABI/stable/sysfs-block | 15 + block/blk-mq-debugfs.c | 1 + block/blk-sysfs.c | 43 ++- block/blk-zoned.c | 402 +++++++++++++++++---------- include/linux/blkdev.h | 10 +- 5 files changed, 320 insertions(+), 151 deletions(-)
Signature · 1 line
2.53.0