Skip to content

Support wm_adsp hibernation for runtime suspend

Stefan Binding linux-sound lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 3 repliesIn review
  2. v13 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- Fix minor error in cs_dsp API documentation
- Add similar patch to use new wm_adsp api for CS35L45

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4firmware: cs_dsp: Add API to hibernate the DSPdrivers/firmware/cirrus/cs_dsp.c include/linux/firmware/cirrus/cs_dsp.h+48 -41 reply
2/4ASoC: codecs: wm_adsp: Allow wm_adsp to hibernate without stopping DSPsound/soc/codecs/wm_adsp.c sound/soc/codecs/wm_adsp.h+7 -01 reply
3/4ASoC: cs35l41: Hibernate wm_adsp on runtime suspendsound/soc/codecs/cs35l41.c+5 -00 replies
4/4ASoC: cs35l45: Hibernate wm_adsp on runtime suspendsound/soc/codecs/cs35l45.c+3 -00 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchRichard Fitzgerald
1/4R-b
2/4R-b
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] Support wm_adsp hibernation for runtime suspend

When the CS35L41 and CS35L45 drivers suspend, they are put into hibernation, and the regmap goes into cache_only, but the firmware is still running, and wm_adsp is not stopped. If userspace attempts to read a firmware control, it will perform a regmap_raw_read() and this will produce an error in the kernel log.

To prevent these spurious errors, add an apis into cs_dsp and wm_adsp to allow wm_adsp to hibernate. In this hibernation mode, reads or writes to the dsp controls would be rejected with -EPERM rather than -EBUSY, and no error will be printed to the kernel log.

Changes Since v1:
- Fix minor error in cs_dsp API documentation
- Add similar patch to use new wm_adsp api for CS35L45

Ricardo Rivera-Matos (1):
ASoC: cs35l45: Hibernate wm_adsp on runtime suspend

Stefan Binding (3):
firmware: cs_dsp: Add API to hibernate the DSP
ASoC: codecs: wm_adsp: Allow wm_adsp to hibernate without stopping DSP
ASoC: cs35l41: Hibernate wm_adsp on runtime suspend

 drivers/firmware/cirrus/cs_dsp.c       | 49 +++++++++++++++++++++++---
 include/linux/firmware/cirrus/cs_dsp.h |  3 ++
 sound/soc/codecs/cs35l41.c             |  5 +++
 sound/soc/codecs/cs35l45.c             |  3 ++
 sound/soc/codecs/wm_adsp.c             |  6 ++++
 sound/soc/codecs/wm_adsp.h             |  1 +
 6 files changed, 63 insertions(+), 4 deletions(-)
Signature · 1 line
2.43.0