Skip to content

Add SSP/TSP power control and DRAM remap support for AST2700

Jamin Lin qemu-arm qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest11 patches 4 repliesIn review
  2. v510 patches 10 repliesSuperseded
  3. v421 patches 24 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v315 patches2 repliesSuperseded

Changes in v6 from the cover letter

1. Move the DRAM remap MemoryRegions from the SCU to the SSP/TSP coprocessor state itself.
2. Set ssp_cpuid/tsp_cpuid directly once the SSP/TSP's armv7m core is realized, instead of pre-guessing them from board code via a QOM property.
3. Correct AST2700 SCU to SCUIO to AST1700

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11hw/arm/aspeed_ast1700: Correct AST2700 SCU to SCUIOhw/arm/aspeed_ast1700.c include/hw/arm/aspeed_ast1700.h+12 -120 replies
2/11hw/arm/ast27x0: Start SSP in powered-off state to match hardware behaviorhw/arm/aspeed_ast27x0-ssp.c+7 -00 replies
3/11hw/arm/ast27x0: Start TSP in powered-off state to match hardware behaviorhw/arm/aspeed_ast27x0-tsp.c+7 -00 replies
4/11hw/arm/ast27x0: Add DRAM alias for SSP SDRAM remaphw/arm/aspeed_ast27x0-fc.c hw/arm/aspeed_ast27x0-ssp.c hw/misc/aspeed_scu.c +2 more+48 -01 reply
5/11hw/arm/ast27x0: Add DRAM alias for TSP SDRAM remaphw/arm/aspeed_ast27x0-fc.c hw/arm/aspeed_ast27x0-tsp.c hw/misc/aspeed_scu.c +1 more+35 -00 replies
6/11hw/misc/aspeed_scu: Implement SSP reset and power-on control via SCU registershw/misc/aspeed_scu.c+109 -01 reply
7/11hw/misc/aspeed_scu: Implement TSP reset and power-on control via SCU registershw/misc/aspeed_scu.c+36 -10 replies
8/11hw/misc/aspeed_scu: Add SCU support for SSP SDRAM remaphw/misc/aspeed_scu.c+62 -01 reply
9/11hw/misc/aspeed_scu: Add SCU support for TSP SDRAM remaphw/misc/aspeed_scu.c+30 -00 replies
10/11tests/functional/aarch64/test_aspeed_ast2700fc: Boot SSP/TSP via PSP and load binaries from DRAMtests/functional/aarch64/test_aspeed_ast2700fc.py+16 -130 replies
11/11docs: Add support vbootrom and update Manual boot for ast2700fcdocs/system/arm/aspeed.rst+35 -70 replies

Reviews trailers per patch

3 of 11 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéKane ChenCédric Le Goater
1/11R-b
2/11T-b R-b
3/11T-b R-b
4/11T-b
5/11T-b
6/11T-b
7/11T-b
8/11T-b
9/11T-b
10/11T-b
11/11T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [PATCH v6 00/11] Add SSP/TSP power control and DRAM remap support for AST2700

This series improves AST2700 platform support by aligning SSP/TSP power and reset behavior with hardware, and enabling DRAM remapping required for proper firmware boot flow.

This series depends on:
[v4,0/9] Refactor AST2700 SCU preparation for coprocessors
https://patchwork.kernel.org/project/qemu-devel/cover/[email protected]/

v1:
1. The changes move DRAM/SDMC initialization earlier to support memory
aliasing, add DRAM aliases for SSP/TSP SDRAM remap, and implement SSP/TSP reset, power-on, and remap controls via SCU registers.
2. With these updates, SSP and TSP can be booted via PSP and load their
binaries from DRAM. Functional tests and documentation are updated accordingly.

v2:
Fix "make check" failure caused by both AST2700 and AST1700 realizing the same TYPE_AST2700_SCU model.

v3:
1. Drop "Move DRAM and SDMC initialization earlier to support memory aliasing"
2. Support SPI/FMC FIFO Mode
3. Add unimplemented devices

v4:
1. Introduce Aspeed2700SCU subclass and separate from generic SCU.
2. Add separate reset handler for AST2700 SCUIO
3. Add AST2700 SCUIO RNG control and data registers
4. Share single SCUIO instance across PSP, SSP, and TSP
5. Fix AST2700 FC hardware strap settings

v5:
1. To speed up the review process, move the following patches into a separate patch series, as they are not directly related to the main topic of this series:

[v4,01/21] hw/misc/aspeed_scu: Introduce Aspeed2700SCU subclass and separate from generic SCU [v4,02/21] hw/misc/aspeed_scu: Add separate reset handler for AST2700 SCUIO
[v4,11/21] hw/arm/ast27x0: Share FMC controller with SSP and TSP
[v4,12/21] hw/arm/aspeed_ast27x0: Add unimplemented Privilege Controller MMIO regions for SSP/TSP (Merged) [v4,13/21] hw/arm/aspeed_ast27x0: Add unimplemented OTP controller MMIO regions for SSP/TSP (Merged) [v4,14/21] hw/block/m25p80: Implement volatile status register write enable for Winbond [v4,15/21] hw/ssi/aspeed_smc: Add Data FIFO-based flash access support for AST2700 [v4,16/21] hw/misc/aspeed_scu: Drop noisy unhandled read logs for AST2700 SCU/SCUIO (Merged) [v4,17/21] hw/misc/aspeed_scu: Add AST2700 SCUIO RNG control and data registers (Merged) [v4,18/21] hw/arm/ast27x0: Share single SCUIO instance across PSP, SSP, and TSP [v4,19/21] hw/arm/aspeed_ast27x0-fc: Fix hardware strap settings (Merged)

2. Add memory_region_transaction_begin() and memory_region_transaction_commit() to protect the transaction.

v6:
1. Move the DRAM remap MemoryRegions from the SCU to the SSP/TSP coprocessor state itself.
2. Set ssp_cpuid/tsp_cpuid directly once the SSP/TSP's armv7m core is realized, instead of pre-guessing them from board code via a QOM property.
3. Correct AST2700 SCU to SCUIO to AST1700

Jamin Lin (11):
hw/arm/aspeed_ast1700: Correct AST2700 SCU to SCUIO hw/arm/ast27x0: Start SSP in powered-off state to match hardware
behavior
hw/arm/ast27x0: Start TSP in powered-off state to match hardware
behavior
hw/arm/ast27x0: Add DRAM alias for SSP SDRAM remap hw/arm/ast27x0: Add DRAM alias for TSP SDRAM remap hw/misc/aspeed_scu: Implement SSP reset and power-on control via SCU
registers
hw/misc/aspeed_scu: Implement TSP reset and power-on control via SCU
registers
hw/misc/aspeed_scu: Add SCU support for SSP SDRAM remap hw/misc/aspeed_scu: Add SCU support for TSP SDRAM remap tests/functional/aarch64/test_aspeed_ast2700fc: Boot SSP/TSP via PSP
and load binaries from DRAM
docs: Add support vbootrom and update Manual boot for ast2700fc

 docs/system/arm/aspeed.rst                    |  42 ++-
 include/hw/arm/aspeed_ast1700.h               |   2 +-
 include/hw/arm/aspeed_coprocessor.h           |   2 +
 include/hw/misc/aspeed_scu.h                  |   5 +
 hw/arm/aspeed_ast1700.c                       |  22 +-
 hw/arm/aspeed_ast27x0-fc.c                    |   4 +
 hw/arm/aspeed_ast27x0-ssp.c                   |  45 ++++
 hw/arm/aspeed_ast27x0-tsp.c                   |  37 +++
 hw/misc/aspeed_scu.c                          | 240 ++++++++++++++++++
 .../aarch64/test_aspeed_ast2700fc.py          |  29 ++-
 10 files changed, 396 insertions(+), 32 deletions(-)
Signature · 1 line
2.43.0