Skip to content

gpu: nova-core: gsp: add RM control command infrastructure

Eliot Courtney dri-devel lkml rust-for-linux 4 versions – New

Get series with b4
b4 am [email protected] change-id 20260225-rmcontrol-bd8a06fc3a0d

Versions newest first

  1. v4 Latest8 patches 0 repliesNew
  2. v39 patches 11 repliesSuperseded
  3. v29 patches 11 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v19 patches27 repliesSuperseded

Changes in v4 from the cover letter

- Collect Reviewed-by on patches that haven't changed too much
- Split NvStatus enum into GspMsgRmStatus/Warning/Error
- Added GspRpcError for Cmdq errors
- Log NvStatus warnings
- Exhaustively match for NvStatus error -> errno errors
- Change a few NvStatus->errno mappings to match openrm
- Drop fault method buffer size patches
- Link to v3: https://patch.msgid.link/[email protected]

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8gpu: nova-core: gsp: add NV_STATUS error code bindingsdrivers/gpu/nova-core/gsp/fw/r570_144/bindings.rs+144 -00 replies
2/8gpu: nova-core: gsp: add GSP-RM status typesdrivers/gpu/nova-core/gsp/fw.rs+508 -00 replies
3/8gpu: nova-core: gsp: add GspRpcError for Cmdq RPC error handlingdrivers/gpu/nova-core/gsp/cmdq.rs drivers/gpu/nova-core/gsp/commands.rs drivers/gpu/nova-core/gsp/fw.rs +1 more+117 -440 replies
4/8gpu: nova-core: gsp: expose GSP-RM internal client and subdevice handlesdrivers/gpu/nova-core/gsp/commands.rs drivers/gpu/nova-core/gsp/fw/commands.rs+83 -10 replies
5/8gpu: nova-core: gsp: add RM control RPC structure bindingdrivers/gpu/nova-core/gsp/fw/r570_144/bindings.rs+11 -00 replies
6/8gpu: nova-core: gsp: add types for RM control RPCsdrivers/gpu/nova-core/gsp/commands.rs drivers/gpu/nova-core/gsp/fw.rs drivers/gpu/nova-core/gsp/fw/r570_144/bindings.rs +1 more+93 -10 replies
7/8gpu: nova-core: use KVVec for SBufferIter flushdrivers/gpu/nova-core/gsp/sequencer.rs drivers/gpu/nova-core/sbuffer.rs+5 -50 replies
8/8gpu: nova-core: gsp: add RM control command infrastructuredrivers/gpu/nova-core/gsp.rs drivers/gpu/nova-core/gsp/fw/rm.rs drivers/gpu/nova-core/gsp/rm.rs +1 more+159 -10 replies

Reviews trailers per patch

4 of 8 patches have a Reviewed-by or Acked-by.

PatchJoel Fernandes
1/8R-b
2/8
3/8
4/8R-b
5/8R-b
6/8
7/8R-b
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/8] gpu: nova-core: gsp: add RM control command infrastructure

Add the infrastructure for sending RM control RPCs. This is needed e.g. for channel allocation.

This series adds:
- NV_STATUS bindings and wrapping GspMsgRmStatus and similar enums, used by generic RPCs and RM control RPCs.
- The necessary bindings for the RM control RPCs.
- RmControlMsgFunction to identify individual control commands, like MsgFunction for GSP commands.
- SBufferIter::read_to_vec (using KVVec) for reading large RPC payloads
- A typed RmControl command that can send RM control commands.

Each new RM control command can be added by extending RmControlMsgFunction, adding the bindings and wrappers for their parameters, and writing a type-safe wrapper to send and receive the reply for the RM control rpc, using RmControl.

This series applies on latest drm-rust-next at the listed commit.

---
Changes in v4:
- Collect Reviewed-by on patches that haven't changed too much
- Split NvStatus enum into GspMsgRmStatus/Warning/Error
- Added GspRpcError for Cmdq errors
- Log NvStatus warnings
- Exhaustively match for NvStatus error -> errno errors
- Change a few NvStatus->errno mappings to match openrm
- Drop fault method buffer size patches
- Link to v3: https://patch.msgid.link/[email protected]

Changes in v3:
- Remove send_rm_control in favour of a typed RmControl
- Print out fault method buffer size at gsp boot
- Remove Reviewed-by and Tested-by on some patches that have changed substantively.
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Introduce typed Handle<T> for RM objects.
- Improve naming
- Improve doc comments
- Change SBufferIter to always use KVVec
- flush_into_kvec -> read_to_vec
- Rebased on latest cmdq locking
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Eliot Courtney (8):
gpu: nova-core: gsp: add NV_STATUS error code bindings
gpu: nova-core: gsp: add GSP-RM status types
gpu: nova-core: gsp: add GspRpcError for Cmdq RPC error handling
gpu: nova-core: gsp: expose GSP-RM internal client and subdevice handles
gpu: nova-core: gsp: add RM control RPC structure binding
gpu: nova-core: gsp: add types for RM control RPCs
gpu: nova-core: use KVVec for SBufferIter flush
gpu: nova-core: gsp: add RM control command infrastructure

 drivers/gpu/nova-core/gsp.rs                      |   1 +
 drivers/gpu/nova-core/gsp/cmdq.rs                 | 112 +++--
 drivers/gpu/nova-core/gsp/commands.rs             |  71 ++-
 drivers/gpu/nova-core/gsp/fw.rs                   | 544 +++++++++++++++++++++-
 drivers/gpu/nova-core/gsp/fw/commands.rs          |  19 +-
 drivers/gpu/nova-core/gsp/fw/r570_144/bindings.rs | 156 +++++++
 drivers/gpu/nova-core/gsp/fw/rm.rs                |  90 ++++
 drivers/gpu/nova-core/gsp/rm.rs                   |   3 +
 drivers/gpu/nova-core/gsp/rm/commands.rs          | 155 ++++++
 drivers/gpu/nova-core/gsp/sequencer.rs            |   9 +-
 drivers/gpu/nova-core/sbuffer.rs                  |   6 +-
 11 files changed, 1117 insertions(+), 49 deletions(-)

---
base-commit: a7a080bb4236ebe577b6776d940d1717912ff6dd
change-id: 20260225-rmcontrol-bd8a06fc3a0d

Best regards,

Signature · 1 line
Eliot Courtney <[email protected]>