Skip to content

hw/arm/smmuv3: Avoid including CONFIG_DEVICES in hw/ header

Philippe Mathieu-Daudé qemu-arm qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 4 repliesIn review
  2. v13 patches 8 repliesSuperseded

Since v2 from the cover letter

- Restrict to ARM SMMUv3
- Address Shameer review comments

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2hw/arm/smmuv3: Have smmuv3_accel_init() take an Error* parameterhw/arm/smmuv3-accel.c hw/arm/smmuv3-accel.h hw/arm/smmuv3.c+10 -112 replies
2/2hw/arm/smmuv3: Avoid including CONFIG_DEVICES in hw/ headerhw/arm/meson.build hw/arm/smmuv3-accel-stubs.c hw/arm/smmuv3-accel.h+55 -442 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchThomas HuthShameer KolothumPierrick Bouvier
1/2R-b R-b
2/2R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/2] hw/arm/smmuv3: Avoid including CONFIG_DEVICES in hw/ header

Since v2:
- Restrict to ARM SMMUv3
- Address Shameer review comments

By inlinining the stubs we can avoid the use of target-specific CONFIG_DEVICES include in a hw/ header, allowing to build the source files including it as common objects.

Philippe Mathieu-Daudé (2):
hw/arm/smmuv3: Have smmuv3_accel_init() take an Error* parameter hw/arm/smmuv3: Avoid including CONFIG_DEVICES in hw/ header

 hw/arm/smmuv3-accel.h       | 41 +----------------------------
 hw/arm/smmuv3-accel-stubs.c | 52 +++++++++++++++++++++++++++++++++++++
 hw/arm/smmuv3-accel.c       |  3 ++-
 hw/arm/smmuv3.c             | 11 +++-----
 hw/arm/meson.build          |  5 ++--
 5 files changed, 61 insertions(+), 51 deletions(-)
 create mode 100644 hw/arm/smmuv3-accel-stubs.c
Signature · 1 line
2.53.0