Skip to content

nvme: multi-path scan races fixes

Keith Busch linux-nvme 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 6 repliesIn review
  2. v12 patches 13 repliesSuperseded

Changes in v2 from the cover letter

* Added reviews and Fixes tags to patch 1

* Redid the logic in patch 2 to match Christoph's suggestions

* Also fixed a compile bug for CONFIG_NVME_MULTIPATH=n

* Added a new patch 3 to fix a dependency race between multiple controller's scan_work

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3nvme-multipath: fix leak on try_module_get failuredrivers/nvme/host/multipath.c+5 -70 replies
2/3nvme-multipath: rescan siblings on last path removaldrivers/nvme/host/core.c drivers/nvme/host/nvme.h+19 -14 replies
3/3nvme: fix unmatched id's under delayed path deletiondrivers/nvme/host/core.c drivers/nvme/host/nvme.h+26 -02 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchNilay ShroffJohn GarryChristoph Hellwig
1/3R-b R-b R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCHv2 0/3] nvme: multi-path scan races fixes

From: Keith Busch <[email protected]>

Changes from v1:

* Added reviews and Fixes tags to patch 1

* Redid the logic in patch 2 to match Christoph's suggestions

* Also fixed a compile bug for CONFIG_NVME_MULTIPATH=n

* Added a new patch 3 to fix a dependency race between multiple controller's scan_work

Keith Busch (3):
nvme-multipath: fix leak on try_module_get failure
nvme-multipath: rescan siblings on last path removal
nvme: fix unmatched id's under delayed path deletion

 drivers/nvme/host/core.c      | 37 ++++++++++++++++++++++++++++++++++-
 drivers/nvme/host/multipath.c | 12 +++++-------
 drivers/nvme/host/nvme.h      |  9 +++++++++
 3 files changed, 50 insertions(+), 8 deletions(-)
Signature · 1 line
2.47.3