Skip to content

mm/damon: strictly respect min_nr_regions

SeongJae Park damon linux-kselftest linux-mm lkml 1 version Applied

Status from this message: [merged mm-stable] mm-damon-test-core-kunit-add-damon_apply_min_nr_regions-test.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesApplied 3/3

Changes from RFC v2 from the cover letter

(https://lore.kernel.org/[email protected])
- Drop RFC
- Rebase to latest mm-new

Patches in v1 All 3 applied

#Subject and filesSizeRepliesApplied
1/3mm/damon/core: split regions for min_nr_regionsmm/damon/core.c+39 -60 repliesApplied
2/3mm/damon/vaddr: do not split regions for min_nr_regionsmm/damon/tests/vaddr-kunit.h mm/damon/vaddr.c+2 -1440 repliesApplied
3/3mm/damon/test/core-kunit: add damon_apply_min_nr_regions() testmm/damon/tests/core-kunit.h+52 -00 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] mm/damon: strictly respect min_nr_regions

DAMON core respects min_nr_regions only at merge operation. DAMON API callers are therefore responsible to respect or ignore that. Only vaddr ops is respecting that, but only for initial start time. DAMON sysfs interface allows users to setup the initial regions that DAMON core also respects. But, again, it works for only the initial time. Users setting the regions for min_nr_regions can be difficult and inefficient, when the min_nr_regions value is high. There was actually a report [1] from a user. The use case was page granular access monitoring with a large aggregation interval.

Make the following three changes for resolving the issue. First (patch 1), make DAMON core split regions at the beginning and every aggregation interval, to respect the min_nr_regions. Second (patch 2), drop the vaddr's split operations and related code that are no more needed. Third (patch 3), add a kunit test for the newly introduced function.

[1] https://lore.kernel.org/CAC5umyjmJE9SBqjbetZZecpY54bHpn2AvCGNv3aF6J=1cfoPXQ@mail.gmail.com

Revision History
================

Changes from RFC v2
(https://lore.kernel.org/[email protected])
- Drop RFC
- Rebase to latest mm-new

Changes from RFC v1
(https://lore.kernel.org/[email protected])
- Split regions every aggregation interval

SeongJae Park (3):
mm/damon/core: split regions for min_nr_regions mm/damon/vaddr: do not split regions for min_nr_regions mm/damon/test/core-kunit: add damon_apply_min_nr_regions() test

 mm/damon/core.c              | 45 ++++++++++++++++++---
 mm/damon/tests/core-kunit.h  | 52 ++++++++++++++++++++++++
 mm/damon/tests/vaddr-kunit.h | 76 ------------------------------------
 mm/damon/vaddr.c             | 70 +--------------------------------
 4 files changed, 93 insertions(+), 150 deletions(-)

base-commit: e4506bd63542dc58b2913cd374c518526c008a2c

Signature · 1 line
2.47.3